add: required field validation wip

magitools · Oct 16, 2024 · 1f4abe1 · 1f4abe1
1 parent 7a93661
commit 1f4abe1
Show file tree

Hide file tree

Showing 2 changed files with 37 additions and 1 deletion.
diff --git a/config/publishers.php b/config/publishers.php
@@ -5,4 +5,23 @@
         'input',
         'select',
     ],
+    'field_validation' => [
+        'input' => [
+            'required_values' => [
+                'type',
+                'label'
+            ],
+            'optional_values' => [
+                'placeholder'
+            ]
+        ],
+        'select' => [
+            'required_values' => [
+
+            ],
+            'optional_values' => [
+
+            ]
+        ]
+    ]
 ];
diff --git a/tests/Feature/PublisherTest.php b/tests/Feature/PublisherTest.php
@@ -8,12 +8,29 @@
         $this->classes = Discover::in(app_path('Publishers'))->classes()->implementing(PublisherContract::class)->get();
     });
 
-    it('publisher inputs are all valid', function () {
+    arch()
+        ->expect('App\Publishers')
+        ->toBeClasses()
+        ->ignoring('App\Publishers\PublisherContract');
+
+    it('publisher inputs are allowed', function () {
         foreach ($this->classes as $class) {
             $instance = new $class;
             $inputs = $instance->getInputs();
             foreach ($inputs as $input) {
+                $validationRules = config('publishers.field_validation');
                 expect($input['input'])->toBeIn(config('publishers.allowed_fields'));
+                expect($input)->toHaveKeys($validationRules[$input['input']]['required_values']);
+            }
+        }
+    });
+    it('publisher inputs have all required options', function() {
+        foreach ($this->classes as $class) {
+            $instance = new $class;
+            $inputs = $instance->getInputs();
+            foreach ($inputs as $input) {
+                $validationRules = config('publishers.field_validation');
+                expect($input)->toHaveKeys($validationRules[$input['input']]['required_values']);
             }
         }
     });