[PE-240] fix: disable comment submit while uploading an image

[aaryan610]

Description

This PR disables the submit button of a comment while creating or editing a comment when an image is being uploaded.

Type of Change

• Bug fix (non-breaking change which fixes an issue)

Summary by CodeRabbit

• New Features

  • Enhanced editor submit button logic to disable based on comment emptiness and editor readiness
  • Improved comment card interaction controls

• Improvements

  • Updated comment card component with more precise state management
  • Refined menu item rendering and icon display
  • Added more granular control for comment submission

[coderabbitai]

Walkthrough

The pull request introduces enhancements to the comment submission logic in the issue comment editor. Two new constants, isEditorReadyToDiscard and isSubmitButtonDisabled, are added to improve the control flow for determining the submit button's disabled state. These changes modify how the editor handles comment submission by incorporating additional checks related to the editor's readiness and comment content.

Changes

File	Change Summary
web/core/components/editor/lite-text-editor/toolbar.tsx	Added isEditorReadyToDiscard and isSubmitButtonDisabled constants to enhance submit button logic
web/core/components/issues/issue-detail/issue-activity/comments/comment-card.tsx	Updated imports, added new state management, modified button rendering and submission logic

Possibly related PRs

• [WEB-2348] fix: allow updating comments with just mentions in them #5471: Modifies LiteTextEditor component and introduces isCommentEmpty function
• [WEB-2944]fix: prevented multiple API calls while updating comment #6352: Updates onEnter function in IssueCommentCard for asynchronous comment updates
• [WEB-3045] fix: sticky placeholder, gray color value #6436: Introduces isCommentEmpty utility function in StickyEditor component

Suggested labels

✍️editor

Suggested reviewers

• rahulramesha
• SatishGandham

Poem

🐰 Coding rabbits hop with glee,
Buttons disabled, logic set free!
Editor's wisdom, now so clear,
Submit when ready, have no fear!
A tale of refs and state divine,
Our code now dances, line by line! 🖥️

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 586a320 and 8a69c04.

📒 Files selected for processing (2)

• web/core/components/editor/lite-text-editor/toolbar.tsx (2 hunks)
• web/core/components/issues/issue-detail/issue-activity/comments/comment-card.tsx (9 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Analyze (javascript)

🔇 Additional comments (3)

web/core/components/editor/lite-text-editor/toolbar.tsx (1)

171-171: LGTM! Submit button disabled state implementation looks good

The disabled state now correctly prevents comment submission during image upload, which aligns with the PR objective.

web/core/components/issues/issue-detail/issue-activity/comments/comment-card.tsx (2)

7-16: LGTM! Clean organization of imports and state management

The code follows good practices with properly organized imports and clear state/ref management.

Also applies to: 50-54

---

177-191: LGTM! Clean implementation of submit button UI

The submit button implementation provides good visual feedback with:

• Proper conditional rendering based on content
• Clear disabled state handling
• Consistent styling following the design system