Refactor BigDecimal handling and fix to_big_decimal.

Updated the `BigDecimal` type alias to `fastnum::D512` for consistency. Modified the `to_big_decimal` function to account for the sign of the input, ensuring proper construction of `BigDecimal` instances.
malik672 · Jan 5, 2025 · bba761d · bba761d
1 parent fd228d3
commit bba761d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/src/lib.rs b/src/lib.rs
@@ -51,7 +51,7 @@ pub mod prelude {
 
     pub type BigInt = fastnum::I512;
     pub type BigUint = fastnum::U512;
-    pub type BigDecimal = fastnum::UD512;
+    pub type BigDecimal = fastnum::D512;
     pub type RoundingMode = fastnum::decimal::RoundingMode;
 }
 

diff --git a/src/utils/types.rs b/src/utils/types.rs
@@ -1,11 +1,14 @@
 use crate::prelude::{BigDecimal, BigInt, BigUint};
 use alloy_primitives::U256;
-use fastnum::decimal::Context;
+use fastnum::decimal::{Context, Sign};
 
 #[inline]
 #[must_use]
 pub const fn to_big_decimal(value: BigInt) -> BigDecimal {
-    BigDecimal::from_parts(value.to_bits(), 0, Context::default())
+    match value.is_negative() {
+        false => BigDecimal::from_parts(value.to_bits(), 0, Sign::Plus, Context::default()),
+        true => BigDecimal::from_parts(value.to_bits(), 0, Sign::Minus, Context::default()),
+    }
 }
 
 #[inline]