refactor!: address mappings for conciseness #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored address mappings to use `AddressMap` and `from_iter` for brevity and readability. This change removes redundant code and improves maintainability. Adjusted constant definitions and function signatures accordingly.
Replaced multiple `FxHashMap::insert` calls with `FxHashMap::from_iter` using a vector. This improves code readability and reduces redundancy.
Inline annotations were added to functions across multiple modules to suggest the compiler to replace function calls with the function's body. This could potentially optimize runtime performance by reducing the overhead of function calls.
Re-enable several Clippy lints for cleaner code validation. Refactor `panic!` calls to `assert!` for better consistency and clarity. Update function arguments to use references where appropriate.
Uncommented the `clippy::must_use_candidate` lint and annotated essential functions with `#[must_use]` attribute. This increases code reliability by enforcing that critical return values are not ignored.
Merged
Make clippy happy
malik672
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored address mappings to use
AddressMapandfrom_iterfor brevity and readability. This change removes redundant code and improves maintainability. Adjusted constant definitions and function signatures accordingly.