Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Books page #31

Closed
2 tasks
JSerwatka opened this issue May 12, 2021 · 2 comments · Fixed by #32
Closed
2 tasks

Books page #31

JSerwatka opened this issue May 12, 2021 · 2 comments · Fixed by #32

Comments

@JSerwatka
Copy link
Contributor

JSerwatka commented May 12, 2021

Description

I can add a page for displaying and searching for books in your library.
Honestly, I have it already coded so I can show you what it looks like, and you can say what you think.

Views:

  • Gallery view - each book is a separate card with a book cover, a title, and an author's name. Clicking on one of the books takes you to the book's clippings in /browse.
  • List view - each book is a separate row in a table with a book cover, a title, an author, and a clippings count. On smaller screens, the author column is hidden. Clicking on one of the books takes you to the book's clippings in /browse.
  • There is a button group that allows you to easily switch between the two views.

Search bar:

  • Allows you to filter books by a book title and an author's name.
  • Hides books that do not match the text of the search bar.

It looks like this:

  • Dashboard
    image
  • Gallery view and search bar
    image
    Of course it is fully responsive:
    image
  • List view and search bar
    image
    And on smaller screens:
    image

Info

There can also be a dedicated link to this page like requested in #30.

TODOs

  • An author is displayed as 'unknown' if it cannot be found in the database. At this point, it affects every book because it is not imported (issue mentioned in Add more structured data when importing clippings & books #5)
  • Book covers are temporarily the same image. Future improvements require using some kind of API (maybe something from here and this package). After fetching all the covers using API, links to the covers should be stored in the db. There should also be an option to edit the cover's link.
@mammuth
Copy link
Owner

mammuth commented May 13, 2021

Love it!

I'm also fine with integrating it before it's completely done/polished.

Btw, regarding the author, we could store the raw clipping files for introducing changes like this with backwards compatibility (see #16).

@JSerwatka
Copy link
Contributor Author

Great! ☺️

I'm also fine with integrating it before it's completely done/polished.

I think the same. I'll make a PR with this feature and move all the TODOs as seperate issues.

Btw, regarding the author...

Sure thing, storing MyClipping will be essential when implementing note editing and clippings deleting features (prevents overwriting).

PS I'll be unavailable for about 2 weeks since tomorrow, so I'll get back to these issues when I'm back

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants