Feature - Gallery and list books views #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add: book list header
mammuth
requested changes
May 15, 2021
|
Nice change @JSerwatka, good job! 🎉 I left a lot of comments, only some of them require action. I did so because I think MR reviews are a nice way for both sides to learn things. Please let me know when you don't want to receive so many comments, then I can save time 🤷 😊 |
No, no, please give your opinion on everything. You are right that this is the best way to learn. Sadly, It turned out that I won't be able to contribute for at least 2 more weeks, so this PR also has to wait 😥 |
mammuth
approved these changes
Jun 22, 2021
|
Looks good! Let me know, when you're done and want it to be merged & deployed. |
|
Ok, we are good to go now! |
|
Merged and deployed 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #31