meta: only check for the C++ compiler when needed #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids the check when it is unnecessary, as that might be unwanted
in some cases. For instance, using `subproject("bragi")` would trigger
the check, even if the intent is only to get the dependency to pull in
the support headers, where no compiler is necessary. This becomes
relevant when building `mlibc-headers`, as that is required for building
a cross-gcc, and as such has no cross-gcc available.
Qwinci
approved these changes
Jun 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids the check when it is unnecessary, as that might be unwanted in some cases. For instance, using
subproject("bragi")would trigger the check, even if the intent is only to get the dependency to pull in the support headers, where no compiler is necessary. This becomes relevant when buildingmlibc-headers, as that is required for building a cross-gcc, and as such has no cross-gcc available.