Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating nighlty to electron 9.x.x #2989

Closed
wants to merge 12 commits into from
Closed

Migrating nighlty to electron 9.x.x #2989

wants to merge 12 commits into from

Conversation

ronny1982
Copy link
Contributor

@ronny1982 ronny1982 commented Jan 24, 2021

Refernces #2933

  • Headers not correctly replaced (e.g. ... Electron ..., X-Referer)
  • Object destroyed error when using fetchUI
  • Popups seem not to work correctly (blank page instead of URL):
    image
  • Various IPC serialization errors
    image
  • 9.0.0 does not display local images electron/electron#23757
  • preview not working for epub extracted to temp directory (file:///var/...)
  • After using HakuNeko, the app only closes the window, but keeps running (need to be killed)
  • HCaptcha not shown correctly (e.g. when loading a manga from MangaLib, or Ngomik)
    image
  • Infinite redirect also with electron 9.4.3 when injecting Engine.Request.fetchUI(new Request('https://mangaspark.com/manga/_/_/?style=list'), '', 60000, true) into HakuNeko (make sure fetchUI window is set to show: true)

@ronny1982 ronny1982 changed the title Migrating nighlty to electron 9.4.1 Migrating nighlty to electron 9.x.x Feb 14, 2021
@ronny1982
Copy link
Contributor Author

ronny1982 commented Feb 14, 2021

Pre-Flight Check

Validate that the current HakuNeko nightly builds for 9.4.3 are running on the following systems by performing the appended (manual) test suite:


Test Environment (Production Systems)


Prerequisites

  • On macOS install ImageMagick
  • On linux install ffmpeg and imagemagick
  • Install Discord and make sure Game Activity is enabled (to verify HakuNeko Rich Presence)

Test Suite

Show Instructions
  1. Download and install/extract the corresponding HakuNeko package for the corresponding testing platform
  2. Start HakuNeko via command line (observe output for possible errors)
  3. Press F12 to open the developer console (observe output for possible errors)
  4. Open the website selection list
  5. Type a search pattern into the website filter (e.g. box)
  6. Select a website from the list (e.g. JaiminisBox)
  7. Update the manga list
  8. Type a search pattern into the manga filter (e.g. one)
  9. Select a manga from the list (e.g. One Piece)
  10. Type a search pattern into the chapter filter (e.g. 5)
  11. Click the preview button for a chapter in the list (e.g. Chapter 951)
  12. Click a thumbnail from the preview to open the reader at the position of the clicked image
  13. Close the reader preview
  14. Open setting and select a manga output directory (e.g. ~/Desktop)
  15. Set output format to Images (*.jpg, *.png, *.webp)
  16. Set post command to
    ffmpeg -version > ffmpeg.ver & convert --version > convert.ver & kindlegen > kindlegen.ver
  17. Confirm settings
  18. Click the download button for a chapter (e.g. Chapter 950)
  19. Open the manga directory and confirm the images are correctly downloaded
  20. In the same directory confirm the *.ver files for ffmpeg, convert and kindlegen are created and not empty
  21. Add a manga to the bookmarks (e.g. One Piece)
  22. Open the website selection again
  23. Clear all filters
  24. Choose 【Bookmarks】
  25. Open settings
  26. Change format to epub
  27. Set post command to
    kindlegen "%PATH%"
  28. Confirm settings
  29. Select the same manga from the list again (e.g. One Piece)
  30. Download the same chapter again (e.g. Chapter 950)
  31. Open the manga directory and confirm the ebook is correctly downloaded as .epub and converted to .mobi
  32. Click the preview button of each downloaded chapter (the chapter downloaded as epub should have a yellow folder icon, the chapter downloaded as Folder with Images a grey folder icon)
  33. Switch to discord and make sure you have no status from HakuNeko
  34. Open settings and turn on Discord Rich Presence
  35. Select any manga from the list (e.g. One Piece)
  36. Click the preview button of any chapter (e.g. Chapter 950)
  37. Switch to discord and make sure you have the status of the currently opened chapter from HakuNeko
  38. Paste in the following link Miss Monochrome: The Animation (Dub)
  39. Select the anime from the manga list
  40. Download any of the episode
  41. Open the manga directory and confirm the video is correctly downloaded as .m3u8 playlist stream and converted to .mkv
  42. Close the developer console
  43. Clear the chapter filter
  44. Click the the Download All Chapters button and confirm the download
  45. Close the window and choose Cancel in the dialog
  46. Close the window again and choose OK in the dialog

Report

Noticed an error when disabling Discord Presence, but it seems to have no further effect
image

@ronny1982
Copy link
Contributor Author

When hCaptcha does not show up, this is very likely because the request was made with fetchUI() which disables images per default. By performing the request with image support fetchUI(..., true) hCaptcha will be shown correctly.

=> Maybe make all fetchUI requests to enable images by default and disable them in certain use cases, where performance matters...

@ronny1982
Copy link
Contributor Author

No activity for some weeks => closed
Feel free to re-open in case of continuing the work

@ronny1982 ronny1982 closed this May 29, 2021
@ronny1982 ronny1982 deleted the electron branch November 13, 2022 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant