Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 404 retry on Instantiate #283

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Conversation

amarbut24
Copy link
Contributor

@amarbut24 amarbut24 commented May 28, 2024

Hello,

We're using the Terraform resource azuread_application

When using this resource we're referencing a template via template_id and we're seeing intermittent errors

{"@level":"error","@message":"Error: Could not instantiate application from template","@module":"terraform.ui","@timestamp":"2024-05-08T02:43:41.520121Z","diagnostic":{"severity":"error","summary":"Could not instantiate application from template","detail":"ApplicationTemplatesClient.BaseClient.Post(): unexpected status 404 with OData error: NotFound: Graph call failed with httpCode=NotFound, errorCode=, errorMessage=, reason=Not Found.","address":"module.dummy-application.azuread_application.saml_application"

I'm wondering if its possible to add a RetryOn404ConsistencyFailureFunc to the post to help with this intermittent issue.
If this looks good/acceptable, what is the timeline to pushing this out to the Terraform Provider?

Copy link
Owner

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @amarbut24, thanks for suggesting this change. This LGTM, I'll include it in the next version of the SDK and it should make it to the AzureAD provider within a few days.

@manicminer manicminer merged commit 4b669b3 into manicminer:main Jun 5, 2024
1 of 2 checks passed
manicminer added a commit that referenced this pull request Jun 5, 2024
@manicminer manicminer added this to the v0.70.0 milestone Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants