Fix segfault due to ViewBox deletetion in CompareSlicesView #1114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samtygier-stfc
force-pushed
the
1110-fix-segfault
branch
from
d28b25a to
5d04205
Compare
Use graveyard to prevent deletion
samtygier-stfc
force-pushed
the
1110-fix-segfault
branch
from
5d04205 to
1fd635d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #1110
Description
Use graveyard to prevent deletion (see #894)
Testing & Acceptance Criteria
Tests should pass. Following steps on bug report should not cause a crash
Documentation
release_notes