ROI support for RITS export #1958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samtygier-stfc
force-pushed
the
1957-rits-roi
branch
from
5a4f1ab to
f0acfec
Compare
Add adjust ROI visibility on tab change
samtygier-stfc
force-pushed
the
1957-rits-roi
branch
from
f0acfec to
3b18581
Compare
Avoid the spectrum plot range being scaled to show zero
JackEAllen
requested changes
Nov 22, 2023
There was a problem hiding this comment.
Looks good! Just a small suggestion so we can have something usable with RITS the nightly in the meantime while we work on #1943 then happy to approve 👍
JackEAllen
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
closes #1957
Description
Add a distinct ROI to be used with the Image/RITS export mode.
Toggle visibility appropriately
Use the ROI when exporting
Testing & Acceptance Criteria
Load the Brass dataset, corrected sample and open beams
Ensure that the spectra file is selected as the sample log
In spectrum view enable normalisation, and set to open beam
On the image export tab, export to RITS
Adjust the ROI to just the sample and export again
Check that the values in the exported file match those displayed in the viewer.
Check that the ROIs toggle sensibly when moving back and forth between tabs.
Documentation
Release notes