brightness percentiles set in live viewer images #1973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samtygier-stfc
requested changes
Nov 6, 2023
| @@ -166,3 +170,8 @@ def update_sibling_histograms(self): | |||
| for img_view in self.histogram_siblings: | |||
| with BlockQtSignals(img_view.hist): | |||
| img_view.hist.setLevels(*hist_range) | |||
|
|
|||
| def use_brightness_percentiles(self, image: np.ndarray, percent_low: int, percent_high: int, *args, **kwargs): | |||
There was a problem hiding this comment.
We don't need the *args, **kwargs part here, as its not being passed through in the this method.
| @@ -35,7 +35,8 @@ def show_image(self, image: np.ndarray) -> None: | |||
| Show the image in the image view. | |||
| @param image: The image to show | |||
| """ | |||
| self.image.setImage(image) | |||
| self.image.use_brightness_percentiles(image, 5, 95) | |||
| self.image.setImage(image, levels=self.image.brightLevels) | |||
There was a problem hiding this comment.
Can MIMiniImageView.setImage() do a check to see if the percentiles are being used, so that levels does not need to be passed in from outside. So this part would be
self.image.use_brightness_percentiles(image, 5, 95)
self.image.setImage(image)
samtygier-stfc
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #1964
Description
In the Live Viewer, the brightness of the image is now set using the 5th and 95th percentiles rather than min/max. This removes outliers and makes the brightness of the images consistent and easier to compare as data is read in.
Percentiles can be changed via
self.image.use_brightness_percentiles(image, low, high)inmantidimaging/gui/windows/live_viewer/live_view_widget.pywherelowandhighare the lower and higher percentiles respectively. The brightness levels are then passed thoughself.image.setImage(image, levels=self.image.brightLevels)in the Live Viewer only put are left as min/max elsewhere.No slowdown has been noticed due to the percentile calculations.
Testing
Data was fed through the Live Viewer to verify the outliers where left out and the image brightness was consistent. This auto levelling is not done in normal operations outside of the Live Viewer.
Acceptance Criteria
Check standard tests and check brightness levels are correct in the Live Viewer.