Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-n auto added to make test in Makefile #1976

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Conversation

MikeSullivan7
Copy link
Collaborator

Issue

Continues #1965

Description

Added "-n auto" to the "make test" command in the Makefile. This reduces the time to run pytest on windows by a factor of ~5-10,

Testing

Check "make test" in Windows and Linux

Acceptance Criteria

See if the make test still runs in an acceptable amount of time.

@coveralls
Copy link

Coverage Status

coverage: 75.447%. remained the same
when pulling cf1fc5a on 1965_multithread_pytests
into 7e39d81 on main.

Copy link
Collaborator

@samtygier-stfc samtygier-stfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Works fine on Linux. We have also been using this flag on github actions, so should be safe.

@samtygier-stfc samtygier-stfc added this pull request to the merge queue Nov 16, 2023
Merged via the queue into main with commit 2d2e2e0 Nov 16, 2023
8 checks passed
@samtygier-stfc samtygier-stfc deleted the 1965_multithread_pytests branch November 16, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants