-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rits transmission error model #1987
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samtygier-stfc
force-pushed
the
1943-rits-transmission
branch
2 times, most recently
from
December 1, 2023 16:53
c5feb66
to
5cc928a
Compare
Co-authored-by: JackEAllen <[email protected]> Co-authored-by: Mike Sullivan <[email protected]>
Co-authored-by: JackEAllen <[email protected]> Co-authored-by: Mike Sullivan <[email protected]>
Co-authored-by: JackEAllen <[email protected]> Co-authored-by: Mike Sullivan <[email protected]>
Co-authored-by: JackEAllen <[email protected]> Co-authored-by: Mike Sullivan <[email protected]>
samtygier-stfc
force-pushed
the
1943-rits-transmission
branch
from
December 4, 2023 14:40
5cc928a
to
4504509
Compare
samtygier-stfc
changed the title
Rits transmission error WIP
Rits transmission error model
Dec 4, 2023
JackEAllen
requested changes
Dec 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and loads into RITS 🥳 Just a minor suggestion to add a docstring for consistency
JackEAllen
approved these changes
Dec 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for adding the docstring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Progresses #1943
Description
This adds methods for calculating the error when exporting spectra for RITS. It implements both methods in the model.
Does not include GUI changes
Testing
Adds testing of the new work
Acceptance Criteria
Tests should pass
Documentation
Will do with the GUI part.