Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rits transmission error model #1987

Merged
merged 11 commits into from
Dec 13, 2023
Merged

Rits transmission error model #1987

merged 11 commits into from
Dec 13, 2023

Conversation

samtygier-stfc
Copy link
Collaborator

@samtygier-stfc samtygier-stfc commented Nov 29, 2023

Issue

Progresses #1943

Description

This adds methods for calculating the error when exporting spectra for RITS. It implements both methods in the model.

Does not include GUI changes

Testing

Adds testing of the new work

Acceptance Criteria

Tests should pass

Documentation

Will do with the GUI part.

@coveralls
Copy link

coveralls commented Nov 29, 2023

Coverage Status

coverage: 75.839% (+0.2%) from 75.633%
when pulling 24848d0 on 1943-rits-transmission
into 774a4e8 on main.

@samtygier-stfc samtygier-stfc force-pushed the 1943-rits-transmission branch 2 times, most recently from c5feb66 to 5cc928a Compare December 1, 2023 16:53
@samtygier-stfc samtygier-stfc changed the title Rits transmission error WIP Rits transmission error model Dec 4, 2023
@samtygier-stfc samtygier-stfc marked this pull request as ready for review December 4, 2023 15:16
@JackEAllen JackEAllen self-requested a review December 5, 2023 09:30
Copy link
Collaborator

@JackEAllen JackEAllen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and loads into RITS 🥳 Just a minor suggestion to add a docstring for consistency

mantidimaging/gui/windows/spectrum_viewer/model.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@JackEAllen JackEAllen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for adding the docstring

@JackEAllen JackEAllen enabled auto-merge December 13, 2023 13:47
@JackEAllen JackEAllen added this pull request to the merge queue Dec 13, 2023
Merged via the queue into main with commit 90c2b6a Dec 13, 2023
8 checks passed
@JackEAllen JackEAllen deleted the 1943-rits-transmission branch December 13, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants