main_window no longer passed to BaseMainWindowView #1989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All good on the linux side. I'll try to give Windows a test later. |
samtygier-stfc
approved these changes
Dec 13, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #1429.
Description
In the Views for the additional windows (operations, spectrum viewer, reconstruct, etc),
self.main_windowis no longer passed to theBaseMainWindowViewthroughsuper().__init__()but is still passed to the view for access. This stops the parent/child relationship between the two QMainWindows.A side effect of this is that the additional windows do not close with the MainWindow is this is now done manually in the Main views
closeEvent().Acceptance Criteria
Open branch in Windows, load in data and then open the Operations, Live Viewer, Spectrum Viewer, and Reconstruction windows and check that the Main window can now sit on top when clicked. All interactions between the additional windows and the main windows should work the same as before.
Check that the program still behaves as it did before in Linux.