Fix ROI Colour Clash #1993
Merged
Fix ROI Colour Clash #1993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename random generator to be more descriptive as colours selected are not random, update tests to reflect method name change, move secon colour in pallet to another location in pallet to avoid colour clash of ROIs when one ROI is added after another
MikeSullivan7
approved these changes
Dec 8, 2023
There was a problem hiding this comment.
Looks good to me, ROIs look distinguishable to me in both the image view and the spectrum.
Only improvement I can think of is maybe increasing the thickness of the ROI boxes in the imageview as I could imagine some of the lighter colours getting lost in busy images. That is only personal preference though and I'm happy to approve as is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Avoids ROI colour clashes if one ROI is added after another. Previously the first two ROI colours were hard to distinguish between each other.
Description
Testing
Acceptance Criteria
Check that ROIs added are distinguishable from one another (in most cases, usually 2-3 ROIs are added) in the image view and spectrum line plot when moved around.
Documentation
N/A - Update documentation as part of #1992 which will enable right clicking of an ROI to change the colour of the ROI.