Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added fits compatibility for live viewer #1996

Merged
merged 3 commits into from
Dec 14, 2023
Merged

added fits compatibility for live viewer #1996

merged 3 commits into from
Dec 14, 2023

Conversation

MikeSullivan7
Copy link
Collaborator

Issue

Closes #1995

Description

.fits files can now be loaded into the Live Viewer

Testing

The brass dataset at (\isis\shares\IMAT\ExampleData\Brass\Corrected_Sample_PH20) was loaded into the Live Viewer and displayed correctly.

Acceptance Criteria

Check that .fits files can be loaded into the live viewer either directly or by simulating live data.

@MikeSullivan7 MikeSullivan7 self-assigned this Dec 11, 2023
@coveralls
Copy link

coveralls commented Dec 11, 2023 •
edited
Loading

Coverage Status

coverage: 75.698% (-0.06%) from 75.755%
when pulling bf281b8 on 1995_Live_Viewer_FITS_compatibility
into 14f2c7f on main.

@JackEAllen JackEAllen self-requested a review December 12, 2023 10:31
JackEAllen
JackEAllen requested changes Dec 12, 2023
View reviewed changes
Copy link
Collaborator

@JackEAllen JackEAllen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I can see .fits files within the live viewer. Just a small suggestion to make use of the suffix property available through image_path and happy to approve. 👍

mantidimaging/gui/windows/live_viewer/presenter.py Outdated Show resolved Hide resolved
@JackEAllen
Copy link
Collaborator

JackEAllen commented Dec 12, 2023 •
edited
Loading

Could you please also add release notes for your changes here docs/release_notes/next/ as part of this PR?
You can copy one of the existing files and rename to something like feature-1996-fits-compatibility and inside it, add the PR number and brief description of changes following the same format as the other release notes.

@JackEAllen JackEAllen self-requested a review December 13, 2023 15:16
@JackEAllen JackEAllen enabled auto-merge December 14, 2023 15:27
@JackEAllen JackEAllen added this pull request to the merge queue Dec 14, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 14, 2023
@JackEAllen JackEAllen added this pull request to the merge queue Dec 14, 2023
Merged via the queue into main with commit bd2510a Dec 14, 2023
8 checks passed
@JackEAllen JackEAllen deleted the 1995_Live_Viewer_FITS_compatibility branch December 14, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samtygier-stfc samtygier-stfc samtygier-stfc approved these changes

@JackEAllen JackEAllen JackEAllen approved these changes

Assignees

@MikeSullivan7 MikeSullivan7

Labels
Type: Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LIVE VIEWER: FITS Compatibility
4 participants
@MikeSullivan7 @coveralls @JackEAllen @samtygier-stfc