create_dev_env: Only try to remove old dev env if it exists #2439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Normally it is safe to try to remove a non existent environment, but in some cases it causes an error. This adds a check, and only removes the env if it exists.
samtygier-stfc
added
the
rebuild_docker 🐋
ashleymeigh2
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #2438
Description
Normally it is safe to try to remove a non existent environment, but in some cases it causes an error. This adds a check, and only removes the env if it exists.
This should fix docker builds.
Testing & Acceptance Criteria
Check if the build docker workflow (
Build & Publish Docker Ubuntu18 & CentOS7) succeeds on the PRDocumentation
Release notes