Add the ruff INP001 rule #2445
Merged
Add the ruff INP001 rule #2445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This check that every directory with a python file has a __init__.py Ignore directories outside the mantidimaging package, as these have some standalone files
samtygier-stfc
force-pushed
the
2444-ruff-implicit-namespace-package
branch
from
678da0e to
bbd5552
Compare
samtygier-stfc
added
the
rebuild_docker 🐋
JackEAllen
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
Thank you turning on the per-file-ignores rule in Ruff. I can confirm that running make ruff will now find missing __init__.py files. Happy to approve! 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #2444
Description
Enable ruff INP001 rule to catch missing
__init__.pyfiles.Use
per-file-ignoresto prevent false positives on stand alone scriptsUpdate ruff to allow negative
per-file-ignoresrulesAdd missing
__init__.pyinpalette_changer/testTesting & Acceptance Criteria
Try removing a
__init__.pyfile and runmake ruffDocumentation
Release notes