[Android Auto] Allow for downstream upgrades #1683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
kmadsen
force-pushed
the
km-allow-callback-surface-override
branch
from
7ea29d8 to
334ef1d
Compare
kmadsen
commented
Sep 21, 2022
extension-androidauto/src/main/java/com/mapbox/maps/extension/androidauto/CarMapSurfaceOwner.kt
Show resolved
Hide resolved
yunikkk
reviewed
Sep 22, 2022
extension-androidauto/src/main/java/com/mapbox/maps/extension/androidauto/MapboxCarMap.kt
Outdated
Show resolved
Hide resolved
kmadsen
force-pushed
the
km-allow-callback-surface-override
branch
2 times, most recently
from
3613a29 to
b12ba1c
Compare
kmadsen
force-pushed
the
km-allow-callback-surface-override
branch
from
712ec5f to
4f1eb41
Compare
kiryldz
approved these changes
Sep 23, 2022
pengdev
reviewed
Sep 23, 2022
extension-androidauto/src/main/java/com/mapbox/maps/extension/androidauto/MapboxCarMap.kt
Show resolved
Hide resolved
pengdev
reviewed
Sep 23, 2022
extension-androidauto/src/main/java/com/mapbox/maps/extension/androidauto/MapboxCarMap.kt
Show resolved
Hide resolved
pengdev
reviewed
Sep 23, 2022
extension-androidauto/src/main/java/com/mapbox/maps/extension/androidauto/MapboxCarMap.kt
Show resolved
Hide resolved
pengdev
reviewed
Sep 23, 2022
extension-androidauto/src/main/java/com/mapbox/maps/extension/androidauto/MapboxCarMap.kt
Show resolved
Hide resolved
pengdev
approved these changes
Sep 23, 2022
mapbox-github-ci-writer-public-1 bot
pushed a commit
that referenced
this pull request
May 5, 2023
* bump gl-native to 10.13.0 and commo to 23.5.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Adding an example of
onClickrequires a compileVersion 33 and a kotlin upgrade. This pull request is adding support to addonClickdownstread #1682, except this change is not blocked by the repo upgrades.Please see the full description and video in the example #1682. This change creates no functional changes, but adds the ability to customize the
SurfaceCallback.Pull request checklist:
@JvmOverloads,@file:JvmName, etc).make update-apito update generated api files, if there's public API changes, otherwise theverify-api-*CI steps might fail.check changelogCI step will fail.v10.[version]release branch fix / enhancement, merge it tomainfirstly and then port tov10.[version]release branch.Fixes: < Link to related issues that will be fixed by this pull request, if they exist >
PRs must be submitted under the terms of our Contributor License Agreement CLA.