Skip to content

Commit

Permalink
[SSDK-542] Update maki icons to SVG (#155)
Browse files Browse the repository at this point in the history
### Description
Fixes [SSDK-542](https://mapbox.atlassian.net/browse/SSDK-542)

- Stop rasterizing Maki SVG assets
- Update scripts/generate_maki.sh to use all latest [SVG icons from Maki repo](https://github.com/mapbox/maki)

### Checklist
- [x] Update nightclub icon
- [x] Update `CHANGELOG`

### Screenshots

| Previous custom icons | Maki repo SVG icons |
| -- | -- |
| ![Simulator Screen Shot - iPhone 14 Plus - 2024-01-23 at 13 51 17](https://github.com/mapbox/mapbox-search-ios/assets/384288/6f3490ef-435b-41d2-bebd-f6e0e4f87437) | ![Simulator Screen Shot - iPhone 14 Plus - 2024-02-07 at 11 31 21](https://github.com/mapbox/mapbox-search-ios/assets/384288/b0f92326-f712-4edc-ae71-0a5d8f6de04a) |

[SSDK-542]: https://mapbox.atlassian.net/browse/SSDK-542
  • Loading branch information
aokj4ck authored Feb 8, 2024
1 parent 5188d63 commit 910b2d1
Show file tree
Hide file tree
Showing 1,081 changed files with 1,132 additions and 823 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ Guide: https://keepachangelog.com/en/1.0.0/

<!-- Add changes for active work here -->

- [SearchUI] Update Maki icons to all SVG, latest versions from https://github.com/mapbox/maki
- [SearchUI] Remove all custom Maki icons
- [Unit Tests] Update and correct tests for iOS 17 using all mocked data.
- [UI Tests] Update and correct tests for iOS 17 using all mocked data.
- [Search] Rename `SearchEngine.reverseGeocoding` function to `SearchEngine.reverse`.
Expand Down
21 changes: 21 additions & 0 deletions Sources/MapboxSearch/PublicAPI/Maki.swift
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
// This file was generated by 'generate_maki.sh' script

// swiftformat:disable:next redundantRawValues
/// Represents static enumeration for all available icons in Mapbox [Maki icon set](https://github.com/mapbox/maki/).
/// Kebab-case was replaced with camelCase.
public enum Maki: String, CaseIterable, Codable {
Expand All @@ -13,6 +16,8 @@ public enum Maki: String, CaseIterable, Codable {
case americanFootball = "american-football"
/// Maki icon "amusement-park"
case amusementPark = "amusement-park"
/// Maki icon "animal-shelter"
case animalShelter = "animal-shelter"
/// Maki icon "aquarium"
case aquarium
/// Maki icon "arrow"
Expand Down Expand Up @@ -163,6 +168,8 @@ public enum Maki: String, CaseIterable, Codable {
case gardenCentre = "garden-centre"
/// Maki icon "garden"
case garden
/// Maki icon "gate"
case gate
/// Maki icon "gift"
case gift
/// Maki icon "globe"
Expand All @@ -183,6 +190,8 @@ public enum Maki: String, CaseIterable, Codable {
case heliport
/// Maki icon "highway-rest-area"
case highwayRestArea = "highway-rest-area"
/// Maki icon "historic"
case historic
/// Maki icon "home"
case home
/// Maki icon "horse-riding"
Expand Down Expand Up @@ -213,6 +222,8 @@ public enum Maki: String, CaseIterable, Codable {
case laundry
/// Maki icon "library"
case library
/// Maki icon "lift-gate"
case liftGate = "lift-gate"
/// Maki icon "lighthouse-JP"
case lighthouseJp = "lighthouse-JP"
/// Maki icon "lighthouse"
Expand All @@ -239,6 +250,8 @@ public enum Maki: String, CaseIterable, Codable {
case music
/// Maki icon "natural"
case natural
/// Maki icon "nightclub"
case nightclub
/// Maki icon "observation-tower"
case observationTower = "observation-tower"
/// Maki icon "optician"
Expand All @@ -251,6 +264,8 @@ public enum Maki: String, CaseIterable, Codable {
case park
/// Maki icon "parking-garage"
case parkingGarage = "parking-garage"
/// Maki icon "parking-paid"
case parkingPaid = "parking-paid"
/// Maki icon "parking"
case parking
/// Maki icon "pharmacy"
Expand Down Expand Up @@ -367,10 +382,14 @@ public enum Maki: String, CaseIterable, Codable {
case telephone
/// Maki icon "tennis"
case tennis
/// Maki icon "terminal"
case terminal
/// Maki icon "theatre"
case theatre
/// Maki icon "toilet"
case toilet
/// Maki icon "toll"
case toll
/// Maki icon "town-hall"
case townHall = "town-hall"
/// Maki icon "town"
Expand All @@ -379,6 +398,8 @@ public enum Maki: String, CaseIterable, Codable {
case triangleStroked = "triangle-stroked"
/// Maki icon "triangle"
case triangle
/// Maki icon "tunnel"
case tunnel
/// Maki icon "veterinary"
case veterinary
/// Maki icon "viewpoint"
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.

This file was deleted.

This file was deleted.

Binary file not shown.
Binary file not shown.
Binary file not shown.

This file was deleted.

Binary file not shown.
Binary file not shown.
Binary file not shown.

This file was deleted.

Binary file not shown.
Binary file not shown.
Binary file not shown.

This file was deleted.

Binary file not shown.
Binary file not shown.
Binary file not shown.

This file was deleted.

Binary file not shown.
Binary file not shown.
Binary file not shown.

This file was deleted.

Binary file not shown.
Binary file not shown.
Binary file not shown.

This file was deleted.

Binary file not shown.
Diff not rendered.
Diff not rendered.

This file was deleted.

Diff not rendered.
Diff not rendered.
Diff not rendered.

This file was deleted.

Diff not rendered.
Diff not rendered.
Diff not rendered.

This file was deleted.

Diff not rendered.
Diff not rendered.
Diff not rendered.
Loading

0 comments on commit 910b2d1

Please sign in to comment.