Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove swifter from mapbox search target #166

Merged
merged 3 commits into from
Feb 8, 2024
Merged

Remove swifter from mapbox search target #166

merged 3 commits into from
Feb 8, 2024

Conversation

aokj4ck
Copy link
Contributor

@aokj4ck aokj4ck commented Jan 31, 2024 •
edited
Loading

Description

  • Change Swifter mock HTTP server to "included in test targets - only" and remove from MapboxSearch framework
  • There's no reason to include Swiftter in MapboxSearch/MapboxSearchUI.
  • This is still required by the test targets
  • Tests run as-before
  • Fixes an issue running the MapboxSearch framework

Checklist

  • Update CHANGELOG

Screenshots

Before After
Screenshot 2024-01-31 at 10 32 40 Runtime crash for linker error Screenshot 2024-01-31 at 10 33 19 Fixed MapboxSearch target settings

@aokj4ck
Remove Swifter test framework from MapboxSearch required libraries
e008895 
- This is still required by the _test_ targets
- Tests run as-before
- Fixes an issue running the MapboxSearch framework
@aokj4ck
Update changelog
251bdcb
@aokj4ck aokj4ck marked this pull request as ready for review January 31, 2024 16:54
@aokj4ck aokj4ck requested review from a team as code owners January 31, 2024 16:54
@aokj4ck
Merge branch 'main' of github.com:mapbox/mapbox-search-ios into remov…
a70d443 
…e-swifter-from-mapbox-search-target

Conflicts:
	CHANGELOG.md
@aokj4ck aokj4ck merged commit 29ae165 into main Feb 8, 2024
4 checks passed
@aokj4ck aokj4ck deleted the remove-swifter-from-mapbox-search-target branch February 8, 2024 14:52
aokj4ck added a commit that referenced this pull request Apr 5, 2024
@aokj4ck
Remove swifter from mapbox search target (#166)
500a1e5 
- Change Swifter mock HTTP server to "included in test targets - only" and remove from MapboxSearch framework
- There's no reason to include Swiftter in MapboxSearch/MapboxSearchUI.
- This is still required by the test targets
- Tests run as-before
- Fixes an issue running the MapboxSearch framework

- [x] Update `CHANGELOG`

| Before | After |
| -- | -- |
| <img width="940" alt="Screenshot 2024-01-31 at 10 32 40" src="https://github.com/mapbox/mapbox-search-ios/assets/384288/83ff9051-f231-4cc9-9ca6-1197c32c0db7"> Runtime crash for linker error | <img width="940" alt="Screenshot 2024-01-31 at 10 33 19" src="https://github.com/mapbox/mapbox-search-ios/assets/384288/f6618fef-c1bb-4b32-a13a-32b9a2187d84"> Fixed MapboxSearch target settings |

Conflicts:
	CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azarovalex azarovalex azarovalex approved these changes

@DzmitryFomchyn DzmitryFomchyn Awaiting requested review from DzmitryFomchyn DzmitryFomchyn is a code owner automatically assigned from mapbox/search-sdk

@4rtzel 4rtzel Awaiting requested review from 4rtzel 4rtzel is a code owner automatically assigned from mapbox/search-sdk

@kried kried Awaiting requested review from kried kried is a code owner automatically assigned from mapbox/search-sdk-ios

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aokj4ck @azarovalex