[SSDK-617] Fix offline tests #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ownloads instead of CGPoint - SSDK-617
- Add assertions to aid development
- Remove unused SearchEngineDelegateStub.subscribe(listener:, selector:)
…617-fix-offline-tests-add-demo
- Update tests to expect offline index observer events - Update changelog - Add debug description strings for CoreOfflineIndexChangeEventType
- Clean up code comments around DefaultLocationProvider.locationManager
…617-fix-offline-tests-add-demo Conflicts: MapboxSearch.xcodeproj/project.pbxproj MapboxSearch.xcodeproj/xcshareddata/xcschemes/Demo.xcscheme Tests/MapboxSearchIntegrationTests/OfflineIntegrationTests.swift
ghost
approved these changes
Apr 9, 2024
2 tasks
aokj4ck
added a commit
that referenced
this pull request
Apr 9, 2024
…ion (#202) ### Description Fixes [SSDK-622](https://mapbox.atlassian.net/browse/SSDK-622) Add optional `language` parameter that has two modes: 1. Absent language parameter / `nil` value will use existing behavior of _just_ the dataset name. 2. A given language parameter will be appended to the dataset name. ### Checklist - [x] Update `CHANGELOG` - [x] Add a non-English language test after #199 is merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes SSDK-617
mbx-mainofflineResultsUpdateddelegate function toSearchEngineDelegateStub.Geometry(point: NSValue(mkCoordinate: CLLocationCoordinate2D))withTileRegionLoadOptions.buildfunction.Checklist
CHANGELOG