Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use node version from .nvmrc file in CI #3274

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Use node version from .nvmrc file in CI #3274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,10 @@ jobs:
fetch-depth: 0
ref: main

- name: Use Node.js 18 x64
uses: actions/setup-node@v3.6.0
- name: Use Node.js from nvmrc
uses: actions/setup-node@v3
with:
node-version: 18
architecture: x64
registry-url: 'https://registry.npmjs.org'
node-version-file: '.nvmrc'

- name: Get version
id: package-version
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/test-all.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v3
with:
node-version: lts/*
node-version-file: '.nvmrc'
- run: npm ci
- run: npm run lint
if: success() || failure()
Expand All @@ -43,7 +43,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v3
with:
node-version: lts/*
node-version-file: '.nvmrc'
- name: Start display server
if: runner.os == 'Linux'
run: nohup Xvfb &
Expand Down Expand Up @@ -73,7 +73,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v3
with:
node-version: lts/*
node-version-file: '.nvmrc'
- run: npm ci
- run: npm run build-dist
- uses: actions/upload-artifact@v3
Expand All @@ -99,7 +99,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v3
with:
node-version: lts/*
node-version-file: '.nvmrc'
- name: install CJK fonts for local ideographs render tests
run: sudo apt install fonts-noto-cjk
- run: npm ci
Expand Down Expand Up @@ -134,7 +134,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v3
with:
node-version: lts/*
node-version-file: '.nvmrc'
- run: npm ci
- name: Start display server
if: runner.os == 'Linux'
Expand Down Expand Up @@ -162,7 +162,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v3
with:
node-version: lts/*
node-version-file: '.nvmrc'
- run: npm ci
- run: npm run build-dist
- run: npm run test-build
Expand Down
7 changes: 3 additions & 4 deletions .github/workflows/upload-benchmarks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,10 @@ jobs:
steps:
- uses: actions/checkout@v4

- name: Use Node.js 18 x64
uses: actions/setup-node@v3.6.0
- name: Use Node.js from nvmrc
uses: actions/setup-node@v3
with:
node-version: 18
architecture: x64
node-version-file: '.nvmrc'

- name: Install
run: npm ci
Expand Down