-
-
Notifications
You must be signed in to change notification settings - Fork 756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a guide on working with large datasets #3307
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3307 +/- ##
=======================================
Coverage 75.45% 75.45%
=======================================
Files 241 241
Lines 19260 19260
Branches 4339 4339
=======================================
Hits 14532 14532
Misses 4728 4728 ☔ View full report in Codecov by Sentry. |
THANKS!! |
I would think about creating more guides before creating this folder. |
I've added this PR to the topic to discuss in out next monthly meeting this Wednesday. Feel free to join and present your work :-) |
Thanks for looking over this @HarelM! The changes all look good, only I'm not sure about the note on the clustering. Once you clue me into the restriction, I'll update that too.
It is certainly a bit strange having a guides section with only one guide! That said, I'm not sure where else to put it and I would prefer to put it out somewhere rather than waiting for more guides. Have you had any thoughts on this in the meantime?
Unfortunately, I wasn't available but glad that you could share it and I hope to come another time. Were there any thoughts on the 'guides' section at the meeting? |
I didn't see any mention of tippecanoe in this guide, which I think is really useful for cutting down large geojson datasources. I use it in my wifidb.net projected to make milions of points more workable. Maybe this tool could be mentioned under "Vector Tiling"? There is also a felt version which supports pmtiles |
@acalcutt Thanks for this! I remember you suggesting this in the original discussion I started. I haven't figured out how to use it yet but I'd love it if you have the time to modify the guide to include it! |
For an example, I use it like this with my geojson file of wifi points but this basically makes a few vector tiles files with layers of wifi points. per zoom level there are tile size limits it tries to reach, so at higher zooms it will prune or combine based one the options you set. you can also tell it to keep making zoom levels until all data can fit into a tile. In the end it gives a nice vector tiles file like |
I decided that this should go in, even if this is the only guide available ATM. |
I'm keen to write a second guide on "Accessibility in MapLibre" soon as it is something I'm researching and implementing for a project anyway. I'm happy to add this single guide on large data for now and add a draft of the accessibility guide within a month. Until then, I'm happy to publish this one by itself. If you want to add an empty one to encourage other contributors that sounds fine too. Alternatively, that encouragement could go on the main Guides page (i.e. https://maplibre.org/maplibre-gl-js/docs/guides/ main page). I don't think either is strictly necessary though. |
@jokroese can you check the open issue related to accessibility (or maybe they got closed)? A person said that this library is not meeting the standards, but I have no clue how to tell what should or shouldn't be... |
I can see that @Malvoz shared a bunch of suggestions for accessibility in 2021 that seem really well-thought-through. Unfortunately, those issues were marked stale and closed. I'll have a look through them :) It would be great if MapLibre could act as an example of best practices for digital map accessibility! |
I couldn't figure out how to turn those into actual code, and I guess no one else either. |
Launch Checklist
Resolves #2823
CHANGELOG.md
under the## main
section.The pull request: