Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vitest script to package.json #5219

Merged
merged 2 commits into from
Dec 16, 2024
Merged

Conversation

ibesora
Copy link
Collaborator

@ibesora ibesora commented Dec 16, 2024

In #4728 jest was replaced with vitest but the jest script was removed instead of updated. That made npm run test to fail.
This PR fixes it by adding a new entry to package.json called vitest.

Launch Checklist

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Link to related issues.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality.
  • Document any changes to public APIs.
  • Post benchmark scores.
  • Add an entry to CHANGELOG.md under the ## main section.

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.82%. Comparing base (5ad1709) to head (0cca08f).
Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5219   +/-   ##
=======================================
  Coverage   91.82%   91.82%           
=======================================
  Files         281      281           
  Lines       38807    38807           
  Branches     6766     6766           
=======================================
+ Hits        35635    35636    +1     
+ Misses       3044     3043    -1     
  Partials      128      128           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ibesora ibesora requested a review from birkskyum December 16, 2024 10:27
@birkskyum
Copy link
Member

What suite is executed by this script?

@HarelM
Copy link
Collaborator

HarelM commented Dec 16, 2024

What did you intended it to run when you added it to the test script?
run-p lint lint-css test-render vitest - see the last invocation.

@birkskyum
Copy link
Member

birkskyum commented Dec 16, 2024

I think the vitest script is supposed to run all the vitest suites, so that would be test-unit test-integration test-build

@ibesora
Copy link
Collaborator Author

ibesora commented Dec 16, 2024

I think the vitest script is supposed to run all the vitest suites, so that would be test-unit test-integration test-build

I just did that.
It's true that having a jest test like we had before might not make a lot of sense.

@HarelM HarelM merged commit c92ef21 into maplibre:main Dec 16, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants