Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary jest configuration file #5258

Merged
merged 12 commits into from
Dec 23, 2024

Conversation

kkokkojeong
Copy link
Contributor

@kkokkojeong kkokkojeong commented Dec 23, 2024

This PR removes the tsconfig.jest.json file.
It is unnecessary it has been replaced from Jest to Vitest 2. (#4728)

Launch Checklist

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Link to related issues.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality.
  • Document any changes to public APIs.
  • Post benchmark scores.
  • Add an entry to CHANGELOG.md under the ## main section.

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.83%. Comparing base (cf8e2ec) to head (245d252).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5258      +/-   ##
==========================================
+ Coverage   91.41%   91.83%   +0.41%     
==========================================
  Files         281      281              
  Lines       38854    38856       +2     
  Branches     6704     6793      +89     
==========================================
+ Hits        35517    35682     +165     
+ Misses       3210     3045     -165     
- Partials      127      129       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kkokkojeong
Copy link
Contributor Author

kkokkojeong commented Dec 23, 2024

I don't know why the integation-ci test fails. It runs normally in local environment.
The latest commit failed for the same reason.

image

@HarelM
Copy link
Collaborator

HarelM commented Dec 23, 2024

Thanks!
Integration tests are failing due to the change to ubuntu 24 in the CI.
Any chance you can copy the puppeteer config changes I've done to this PR (the other PR mixed two different fixes...)?

@kkokkojeong
Copy link
Contributor Author

@HarelM I'll update after your PR merges with the main branch

@HarelM
Copy link
Collaborator

HarelM commented Dec 23, 2024

Better to have it have as I'm waiting for feedback on the other PR...

@HarelM HarelM enabled auto-merge (squash) December 23, 2024 09:20
@HarelM HarelM merged commit f967780 into maplibre:main Dec 23, 2024
17 checks passed
@kkokkojeong kkokkojeong deleted the remove-jest-config branch December 26, 2024 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants