-
-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use FileSystemFileHandle
to modify a file on the local filesystem
#965
Conversation
74ca4f1
to
0999651
Compare
FileSystemFileHandle
to modify a file in the local file systemFileSystemFileHandle
to modify a file on the local file system
FileSystemFileHandle
to modify a file on the local file systemFileSystemFileHandle
to modify a file on the local filesystem
Yes, I believe there is a need to cover this in tests although I struggled with Cypress and file open button. |
The this pull request removes the html input element. I found a way to test with it but it would require to somehow mock the File System Access API and I can't find a solution for this.
maputnik-showcase1.mp4 |
Overall this looks like a great improvement, I'm happy to see that file API finally made it to the browsers... |
Co-authored-by: Harel M <[email protected]>
Let me know if you managed to find a way to test this... |
From my pr description:
I didn't break any tests with this pr, so the functionality hasn't been covered previously. I'd write some tests to cover it but will need some guidance. |
I can't find anything when using Google about Cypress and this new API. |
I looked into it but couldn't find a way with Cypress tests, too. Maybe another test setup for unit tests would be beneficial? I changed "Download HTML" to "Create HTML" to be more in line. From my point of view the pr is ready to get merged. (: |
Thanks! |
Launch Checklist
CHANGELOG.md
under the## main
section.Changes
Known Limitations
Issue
Screenshots
Menu
Open modal
Save modal