chore: cleanup useless decodeURIComponent() calls #1002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
acalcutt
approved these changes
Oct 13, 2023
|
can you rebase this, it doesn't look like i have the permission to do it on this PR |
Signed-off-by: Martin d'Allens <[email protected]>
Fix 1: \d\.?\d* can backtrack catastrophically \d(\.\d*)? is safer Fix 2: Useless parenthesis around "enc:" Fix 3: The httpTester regex was misleading. It did not really check for "http". Simplified to show its true meaning. The behaviour should not have changed. Signed-off-by: Martin d'Allens <[email protected]>
Signed-off-by: Martin d'Allens <[email protected]>
Signed-off-by: Martin d'Allens <[email protected]>
Caerbannog
force-pushed
the
simplify-decoding
branch
from
ba7317a to
869ab04
Compare
|
OK, rebased. |
alex-kowalczyk
added a commit
to alex-kowalczyk/tileserver-gl
that referenced
this pull request
Oct 20, 2023
…ng of vector tiles Root cause: modified regex in maptiler#1002 caused URLs to be broken. Fixed by reverting previous regexes. Tests: * Confirmed by building and running locally with formerly breaking config.json and style json. * Run tests via Dockerfile_test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a slight simplification of the code.
The explanation is here: #981 (comment)
I tested it very basically. I just looked at a few static maps from my history.