feat: added-cache-id #1307
Open
feat: added-cache-id #1307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Majid <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -242,6 +244,8 @@ | |||
| } | |||
| } else if (inputType === 'mbtiles') { | |||
| sourceType = 'mbtiles'; | |||
| tileJSON['cacheId']= await getFileHash(inputFile) | |||
Check notice
Code scanning / CodeQL
Semicolon insertion Note
| rs.on('error', reject); | ||
| rs.on('data', chunk => hash.update(chunk)); | ||
| rs.on('end', () => resolve(hash.digest('base64'))); | ||
| }) |
Check notice
Code scanning / CodeQL
Semicolon insertion Note
|
For the test data, there is a link to it here https://github.com/maptiler/tileserver-gl?tab=readme-ov-file#getting-started-with-linux-cli under "Test from command line" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
cache-idquery parameter to the tiles url. This helps to refresh client side cache when we update mbtiles on the server as its file hash changes and browser invalidates older cachesif file is mbtile it uses fileHash
if file is pmtiles it uses mtime (last modified time)
I need some more information about the tests. On my machine I was not able to run tests as it was missing test data folder. is there any way I can access them?
Thanks