Fix inconsistent naming of icons #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace dashes with underscores everywhere to match the OpenMapTiles schema. Fix other name inconsistencies with OpenMapTiles (american_football, doctors, toilets). Inonsistency: stroke vs stroked. Apply the Maki naming (stroked). Inspired by issue maputnik#64.
pathmapper
reviewed
Oct 13, 2023
There was a problem hiding this comment.
Changes LGTM, thanks!
I did not rebuild the sprites because I have other changes I want to suggest in future PRs.
Can you please rebuild the sprites for this PR and include them?
We would like to have always matching inconset/sprites in the repo. Also the changes in the sprites should reflect only the changes in the iconset which wouldn't be the case if you would rebuild the sprites for another PR including also the changes here.
|
OK, I rebuilt the sprites. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
Inspired by issue #64.
I did not rebuild the sprites because I have other changes I want to suggest in future PRs.