fix: vim keymap precedence (fix enter in insert mode) (#3395)

This is a better and more correct solution

frontend/src/core/codemirror/__tests__/__snapshots__/setup.test.ts.snap

@@ -166,6 +166,17 @@ exports[`snapshot all duplicate keymaps > vim keymaps 2`] = `
       "shift": "deleteCharBackward",
     },
   ],
+  "Enter": [
+    {
+      "key": "Enter",
+      "run": "acceptCompletion",
+    },
+    {
+      "key": "Enter",
+      "run": "<no name>",
+      "shift": "<no name>",
+    },
+  ],
   "Escape": [
     {
       "key": "Escape",

frontend/src/core/codemirror/__tests__/setup.test.ts

@@ -115,7 +115,7 @@ describe("snapshot all duplicate keymaps", () => {
     );
     // Total duplicates:
     // if this changes, please make sure to validate they are not conflicting
-    expect(Object.values(duplicates).flat().length).toMatchInlineSnapshot("17");
+    expect(Object.values(duplicates).flat().length).toMatchInlineSnapshot("19");
     expect(duplicates).toMatchSnapshot();
   });
 });

frontend/src/core/codemirror/keymaps/keymaps.ts

@@ -6,7 +6,6 @@ import { type Extension, Prec } from "@codemirror/state";
 import { type EditorView, keymap } from "@codemirror/view";
 import { vim } from "@replit/codemirror-vim";
 import { vimKeymapExtension } from "./vim";
-import { once } from "@/utils/once";
 
 export const KEYMAP_PRESETS = ["default", "vim"] as const;
 
@@ -35,8 +34,9 @@ export function keymapBundle(
       ];
     case "vim":
       return [
+        keymap.of(defaultKeymap),
         // delete the cell on double press of "d", if the cell is empty
-        Prec.highest(
+        Prec.high(
           doubleCharacterListener(
             "d",
             (view) => view.state.doc.toString() === "",
@@ -49,31 +49,16 @@ export function keymapBundle(
             },
           ),
         ),
-        keymap.of(defaultVimKeymap()),
-        vim({ status: false }),
+        Prec.highest(vim({ status: false })),
         // Needs to come after the vim extension
-        vimKeymapExtension(callbacks),
+        Prec.highest(vimKeymapExtension(callbacks)),
       ];
     default:
       logNever(config.preset);
       return [];
   }
 }
 
-const defaultVimKeymap = once(() => {
-  const toRemove = new Set(["Enter", "Ctrl-v", "ArrowLeft", "ArrowRight"]);
-  // Remove conflicting keys from the keymap
-  // Enter (<CR>) adds a new line
-  //   - it should just go to the next line
-  // Ctrl-v goes to the bottom of the cell
-  //   - should enter blockwise visual mode
-  // ArrowLeft/ArrowRight exit blockwise visual mode
-  //   - should keep blockwise, but continue with cursor movement
-  return defaultKeymap.filter(
-    (k) => !toRemove.has(k.key || k.mac || k.linux || k.win || ""),
-  );
-});
-
 /**
  * Listen for a double keypress of a character and call a callback.
  */