-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: disable heading detection for carousel, accordion and tabs #2154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
for more information, see https://pre-commit.ci
mscolnick
approved these changes
Aug 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice job! and thank you for the tests!
mscolnick
changed the title
fix #2130: disable heading detection for carousel, accordion and tabs
fix #2139: disable heading detection for carousel, accordion and tabs
Aug 29, 2024
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.8.5-dev4 |
metaboulie
changed the title
fix #2139: disable heading detection for carousel, accordion and tabs
fix: disable heading detection for carousel, accordion and tabs
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2139
📝 Summary
This pull request addresses the issue of excluding certain headings within specific tags (
marimo-carousel
,marimo-tabs
,marimo-accordion
) from being included in the document outline generated by thegetOutline
function, ensures that the document outline generated by thegetOutline
function is accurate and excludes irrelevant headings within specified custom tags.🔍 Description of Changes
Changes Made
excludedTags
containing the tagsmarimo-carousel
,marimo-tabs
, andmarimo-accordion
.getOutline
Function: Modified thegetOutline
function to skip headings that are within any of the tags specified in theexcludedTags
array.Problem Addressed
Previously, the
getOutline
function would include all headings (h1
,h2
,h3
) in the document, even if they were within certain custom tags likemarimo-carousel
,marimo-tabs
, andmarimo-accordion
. This was problematic because headings within these tags should not be part of the document outline.Resolution
The problem was resolved by:
getOutline
function to determine if a heading is within any of the excluded tags.📋 Checklist
📜 Reviewers
@akshayka OR @mscolnick