-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Polars GroupBy Issue #3348 #3349
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
⚙️ Control Options:
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mscolnick
approved these changes
Jan 6, 2025
Co-Authored-By: Myles Scolnick <[email protected]>
for more information, see https://pre-commit.ci
Co-Authored-By: Myles Scolnick <[email protected]>
mscolnick
force-pushed
the
devin/1736171196-groupby-polars-fix
branch
from
January 6, 2025 14:48
c0a40ba
to
12d1347
Compare
Devin is currently unreachable - the session may have died. |
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.10.10-dev20 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Polars GroupBy Issue #3348
This PR fixes an issue where group by transformations in Polars were not correctly referencing the original column names in the generated code.
Changes
print_code.py
to usepl.col()
for group by columnstest_polars_groupby_alias
to verify proper column name handling in group by transformationsTesting
Added a new test that:
pl.col()
for both group by and aggregation columnsLink to Devin run
https://app.devin.ai/sessions/ba11f083aa6b4f63857d6f1fbe11ac00