Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editor): Add keyboard shortcuts for completion navigation #3382

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

metaboulie
Copy link
Contributor

@metaboulie metaboulie commented Jan 9, 2025

📝 Summary

Add Alt-J/K (Ctrl-J/K on macOS) shortcuts to navigate through the completion menu, inspired by Vim:

  • Alt-J/Ctrl-J: Move down in completion list
  • Alt-K/Ctrl-K: Move up in completion list

This provides a more efficient way to navigate completions without using arrow keys.

Screen.Recording.2025-01-09.at.10.55.02.mov

📋 Checklist

  • I have read the contributor guidelines.
  • For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on Discord, or the community discussions (Please provide a link if applicable).
  • I have added tests for the changes made.
  • I have run the code and verified that it works as expected.

📜 Reviewers

@akshayka OR @mscolnick

Copy link

vercel bot commented Jan 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marimo-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2025 2:42am
marimo-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2025 2:42am

Copy link
Contributor

@mscolnick mscolnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@mscolnick mscolnick merged commit bf49994 into marimo-team:main Jan 9, 2025
17 of 19 checks passed
Copy link

github-actions bot commented Jan 9, 2025

🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.10.10-dev45

@metaboulie metaboulie deleted the eugene/autocmp branch January 9, 2025 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants