-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cache iteration: various fixes- will invalidate exisiting cache #3480
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
for more information, see https://pre-commit.ci
Nice!
This should be its own PR, with perhaps some API discussion up front first.
May as well include in a separate PR? |
@dmadisetti I know this is marked as a draft, but just double checking — let us know if and when you want a review. |
Breaking up the PRs, I think this is fine to be reviewed and merge. Sorry it's a little messy- rebased from some old branches. I'll try to get the other hash breaking change in before next release so these can go out together |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice fixes! Just a few small comments
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.10.16-dev15 |
This has fixes for:
Following PR changes:
@persistent_cache
api (this shouldn't cache bust, so I might just follow up) (Cache interface options #2653)