Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cache iteration: various fixes- will invalidate exisiting cache #3480

Merged
merged 9 commits into from
Jan 22, 2025

Conversation

dmadisetti
Copy link
Collaborator

@dmadisetti dmadisetti commented Jan 17, 2025

This has fixes for:

Following PR changes:

Copy link

vercel bot commented Jan 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marimo-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2025 1:29am
marimo-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2025 1:29am

@akshayka
Copy link
Contributor

Nice!

Expand @persistent_cache api (this shouldn't cache bust, so I might just follow up) (#2653)

This should be its own PR, with perhaps some API discussion up front first.

Detect when execution hash relies on a another hash object (cache breaking) (#3270)
Allow for pickle hash as fallback for "unhashable" variables (#3270)

May as well include in a separate PR?

@akshayka
Copy link
Contributor

@dmadisetti I know this is marked as a draft, but just double checking — let us know if and when you want a review.

@dmadisetti
Copy link
Collaborator Author

Breaking up the PRs, I think this is fine to be reviewed and merge. Sorry it's a little messy- rebased from some old branches.

I'll try to get the other hash breaking change in before next release so these can go out together

@dmadisetti dmadisetti changed the title draft: cache iteration- various fixes- will invalidate exisiting cache cache iteration: various fixes- will invalidate exisiting cache Jan 21, 2025
Copy link
Contributor

@akshayka akshayka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fixes! Just a few small comments

marimo/_save/ast.py Outdated Show resolved Hide resolved
marimo/_save/ast.py Outdated Show resolved Hide resolved
marimo/_save/ast.py Outdated Show resolved Hide resolved
marimo/_save/ast.py Outdated Show resolved Hide resolved
marimo/_save/hash.py Show resolved Hide resolved
marimo/_save/save.py Outdated Show resolved Hide resolved
marimo/_save/ast.py Outdated Show resolved Hide resolved
@akshayka akshayka merged commit ca092e9 into main Jan 22, 2025
34 checks passed
@akshayka akshayka deleted the dm/cache-updates branch January 22, 2025 05:42
Copy link

🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.10.16-dev15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants