Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pdksync - add dependency marktlib #24

Merged
merged 1 commit into from
Jul 16, 2024
Merged

pdksync - add dependency marktlib #24

merged 1 commit into from
Jul 16, 2024

Conversation

Lightning-
Copy link
Contributor

add dependency marktlib
pdk version: 3.2.0

@oxc
Copy link
Contributor

oxc commented Jul 16, 2024

This will get released as a major version change, right?

@Lightning-
Copy link
Contributor Author

not necessarily as a major: currently we're just adding this as a dependency to all of our modules but without being used (yet).

starting a great makeover of all modules we own, those reworks might trigger a minor or major release, depending on the changes. but most likely there will drop out some majors as our changes will likely be big and incisive ;).

but the dependency to marktlib should be some sort of no-brainer (for now) because marktlib itself just provides features without actively replacing other existing mechanics or interfering with other modules.

@oxc
Copy link
Contributor

oxc commented Jul 16, 2024

If this ever gets used, people need to actively add this to their Puppetfile, which IMHO warrants a major version bump according to semver, because nobody reads CHANGELOGs on every minor bump.

Relying on the first person to use the new types/features to think of this is IMHO a recipe for failure :) (Or alternatively: if it's not used yet, what good is having the dependency in the first place. Just add it when you need it.)

@Lightning-
Copy link
Contributor Author

because nobody reads CHANGELOGs on every minor bump

ok, thinking this way ... indeed, we need a major 😆

but as said, we won't release just to introduce a new dependency that's not used yet. the changes being worked on are the more interesting part, and work just started.

so stay tuned 😄

@Lightning- Lightning- merged commit 544455e into main Jul 16, 2024
4 checks passed
@Lightning- Lightning- deleted the pdksync_marktlib branch July 16, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants