m_sentPackets sequence fix & some other minor changes #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a reliable channel is dormant (no messages sent) for an extended period of time, it will trigger an assert when it reactivates (the next time you send a message). This occurs because reliable's sequence number will continue to increment, and the SequenceBuffer will assume the packet is too old when we try to insert it. Since we're sending, we know that's not true, so this adds a new `InsertAndIgnoreAge` method to `SequenceBuffer` and converts the reliable channel sending to use that instead. Fixes mas-bandwidth#138 and mas-bandwidth#146.
`SentPacketEntry::acked` never had a `1` written to it, so the code that checked for it was no-op. This removes the field and instead removes the acked packet from the `m_sentPackets`, so that we do not double-process a packet (which we would do previously, but it would just be a no-op since the packets were already removed from the `m_messageSendQueue`.
jorgenpt
force-pushed
the
sentpackets-sequence-fix
branch
from
e384bc7 to
a0204b8
Compare
|
Not sure why this is failing on macOS, I'll investigate. |
|
Huh. It ran fine when it was re-run, and I wasn't able to reproduce. |
|
@gafferongames whenever you have time I'd love to hear your thoughts on this PR. It looks like a great fix to get rid of having to send dummy reliable packets to avoid the issue, but was curious as to what you think. |
|
I'm concerned around the heisenbug on tests. Please run locally on MacOS and loop the tests (while true). If it's an intermittent timing related test failure, then this approach usually catches it. |
|
I believe this has been fixed in another PR. If I'm wrong, please let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ackedfield which isn't being used