Add service fee claim page #733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
pivilartisant
commented
Jun 10, 2024
pivilartisant
commented
Jun 10, 2024
src/pages/IndexPage/Layouts/LoadingLayout/RedeemLayout/ClaimRedeem.tsx
Outdated
Show resolved
Hide resolved
pivilartisant
commented
Jun 10, 2024
pivilartisant
commented
Jun 10, 2024
Thykof
requested changes
Jun 11, 2024
pivilartisant
force-pushed
the
add-service-fee-claim-page
branch
2 times, most recently
from
21e2909 to
0af22b2
Compare
Thykof
reviewed
Jun 11, 2024
Thykof
reviewed
Jun 11, 2024
pivilartisant
force-pushed
the
add-service-fee-claim-page
branch
from
13f6bdc to
4246af1
Compare
Thykof
reviewed
Jun 11, 2024
src/pages/IndexPage/Layouts/BridgeRedeemLayout/BridgeRedeemLayout.tsx
Outdated
Show resolved
Hide resolved
src/pages/IndexPage/Layouts/BridgeRedeemLayout/BridgeRedeemLayout.tsx
Outdated
Show resolved
Hide resolved
src/pages/IndexPage/Layouts/BridgeRedeemLayout/BridgeRedeemLayout.tsx
Outdated
Show resolved
Hide resolved
pivilartisant
force-pushed
the
add-service-fee-claim-page
branch
from
f7f8c0f to
13c2648
Compare
Thykof
reviewed
Jun 11, 2024
src/pages/IndexPage/Layouts/BridgeRedeemLayout/BridgeRedeemLayout.tsx
Outdated
Show resolved
Hide resolved
pivilartisant
commented
Jun 11, 2024
pivilartisant
commented
Jun 11, 2024
pivilartisant
commented
Jun 11, 2024
pivilartisant
commented
Jun 11, 2024
Thykof
requested changes
Jun 12, 2024
src/pages/IndexPage/Layouts/BridgeRedeemLayout/BridgeRedeemLayout.tsx
Outdated
Show resolved
Hide resolved
Thykof
requested changes
Jun 12, 2024
Thykof
requested changes
Jun 12, 2024
src/pages/IndexPage/Layouts/LoadingLayout/RedeemLayout/ClaimRedeem.tsx
Outdated
Show resolved
Hide resolved
pivilartisant
force-pushed
the
add-service-fee-claim-page
branch
from
550f92a to
210e62e
Compare
Thykof
approved these changes
Jun 12, 2024
This reverts commit 13c2648.
pivilartisant
force-pushed
the
add-service-fee-claim-page
branch
from
210e62e to
72fdf7c
Compare
peterjah
pushed a commit
that referenced
this pull request
Jul 16, 2024
* add service fees on claim page * add success amount * update usehandleBurnRedeem hook * clean utils * move logic to initClaim.tsx * clean * rename amount to receive * add outputAmount check in succesClaim * refacto getAmountToReceive and edit tests * refactor getAmountToreceive * remove undefined from success claim props * add comments * refactor input and output * add outputAmount to success page * clean bridgeRedeemLayout * fix changeAmount fn * Revert "fix changeAmount fn" This reverts commit 13c2648. * clean changeAmount fn * set inputs undefined * exp => inputAmount to bigint * update ui kit with npm link, PR #459 * fix retrievePercent * fix Amount * fix tests * rename variable * rename var + fix component * fix claim page wwhen failing to parse 1,000 to bigint * remove comment * prevent crashing from parsing a string with , seperator * seperate send from received * refactor getAmountReceived() * refactor getAmountReceived() p2 * clean claim page * rename amount in BridgeRedeemLayout.tsx * compare struct equal and fix test * rename _outputAmount --------- Co-authored-by: Nathan Seva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.