New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix db sanity check #4820

Merged

modship merged 4 commits into mainnet_2_3 from fix_db_sanity_check

Jan 16, 2025

Member

modship commented Jan 15, 2025

document all added functions
try in sandbox /simulation/labnet
- if part of node-launch, checked using the resync_check flag
unit tests on the added/changed features
- make tests compile
- make tests pass
add logs allowing easy debugging in case the changes caused problems
if the API has changed, update the API specification


          FinalState(is_db_valid): add check for deferred calls keys

2b4985f

modship linked an issue

that may be closed by this pull request

_is_db_valid sanity check does not handle deferred_calls #4817

Closed

Leo-Besancon and others added 2 commits

January 15, 2025 16:52


          fix address deserialization

4b4ea10


          clippy

f5e524c

modship requested a review from Leo-Besancon

January 15, 2025 16:07

Leo-Besancon approved these changes

View reviewed changes

Collaborator

Leo-Besancon left a comment

Thanks a lot!


          Fix: use Slot::from_bytes_key instead of SlotDeserializer

fecf078

modship merged commit 0979aa5 into mainnet_2_3

12 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet