Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

740-3 wallet package #769

Merged
merged 18 commits into from
Oct 19, 2023
Merged

740-3 wallet package #769

merged 18 commits into from
Oct 19, 2023

Conversation

Thykof
Copy link
Contributor

@Thykof Thykof commented Oct 2, 2023 •
edited
Loading

@Thykof Thykof marked this pull request as draft October 2, 2023 22:36
@Thykof Thykof linked an issue Oct 2, 2023 that may be closed by this pull request
Improve wallet readibility #740
Closed
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 2, 2023
View reviewed changes
pkg/prompt/import.go Dismissed Show dismissed Hide dismissed
@codecov
Copy link

codecov bot commented Oct 2, 2023 •
edited
Loading

Codecov Report

Attention: 133 lines in your changes are missing coverage. Please review.

Comparison is base (53bc78d) 42.31% compared to head (470afbe) 43.77%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #769      +/-   ##
==========================================
+ Coverage   42.31%   43.77%   +1.45%     
==========================================
  Files          36       41       +5     
  Lines        2363     2652     +289     
==========================================
+ Hits         1000     1161     +161     
- Misses       1245     1347     +102     
- Partials      118      144      +26
Files Coverage Δ
pkg/walletmanager/testUtils.go 100.00% <100.00%> (ø)
pkg/walletmanager/validation.go 100.00% <100.00%> (ø)
pkg/wallet/account/account.go 62.27% <61.53%> (-0.23%) ⬇️
pkg/types/encrypted_private_key.go 40.83% <40.00%> (+0.42%) ⬆️
pkg/walletmanager/retrocompatibility.go 37.77% <37.77%> (ø)
pkg/walletmanager/filesystem.go 54.68% <54.68%> (ø)
pkg/walletmanager/wallet.go 56.25% <56.25%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Thykof Thykof changed the base branch from main to 740-2-account-package October 4, 2023 15:42
@Thykof Thykof force-pushed the 740-3-wallet-package branch from 4aab66d to 2539a7e Compare October 4, 2023 19:37
@Thykof Thykof force-pushed the 740-2-account-package branch from fdde8c5 to b978ec0 Compare October 4, 2023 19:45
@Thykof Thykof force-pushed the 740-3-wallet-package branch from 8877ab7 to 6ea7bcb Compare October 4, 2023 19:47
@Thykof Thykof force-pushed the 740-2-account-package branch from c5d04ca to 85558dd Compare October 9, 2023 07:54
@Thykof Thykof force-pushed the 740-3-wallet-package branch 7 times, most recently from 96045b3 to aadd75c Compare October 10, 2023 09:01
@Thykof Thykof force-pushed the 740-2-account-package branch from 33baa18 to 37b129f Compare October 12, 2023 08:43
@Thykof Thykof force-pushed the 740-3-wallet-package branch 4 times, most recently from cf440d9 to 588becc Compare October 12, 2023 09:57
@Thykof Thykof force-pushed the 740-2-account-package branch from f7d7e39 to 19cf9be Compare October 12, 2023 12:00
@Thykof Thykof force-pushed the 740-3-wallet-package branch 3 times, most recently from 5dff343 to d8d0bb2 Compare October 12, 2023 14:18
@Thykof Thykof force-pushed the 740-2-account-package branch from ebcd5b7 to 0bc0194 Compare October 13, 2023 14:43
@Thykof Thykof force-pushed the 740-3-wallet-package branch from d8d0bb2 to d218a9f Compare October 13, 2023 14:45
@Thykof Thykof force-pushed the 740-2-account-package branch from 0bc0194 to 97ab5b0 Compare October 13, 2023 15:14
@Thykof Thykof force-pushed the 740-3-wallet-package branch from d218a9f to 47859eb Compare October 13, 2023 15:19
@Thykof Thykof force-pushed the 740-2-account-package branch from 97ab5b0 to 24cf855 Compare October 17, 2023 13:01
@Thykof Thykof force-pushed the 740-3-wallet-package branch from 47859eb to 2dfed0c Compare October 17, 2023 13:01
Base automatically changed from 740-2-account-package to main October 17, 2023 14:18
@Thykof Thykof force-pushed the 740-3-wallet-package branch from 2dfed0c to 3a00492 Compare October 17, 2023 14:23
@Thykof Thykof marked this pull request as ready for review October 17, 2023 14:26
@Thykof Thykof requested a review from gregLibert October 18, 2023 22:40
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Thykof Thykof merged commit aa8793a into main Oct 19, 2023
20 checks passed
@Thykof Thykof deleted the 740-3-wallet-package branch October 19, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterjah peterjah peterjah approved these changes

@gregLibert gregLibert gregLibert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve wallet readibility
3 participants
@Thykof @gregLibert @peterjah