Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

740-4 use new wallet package #778

Merged
merged 9 commits into from
Oct 26, 2023

CR

8453eb5
Select commit
Loading
Failed to load commit list.
Merged

740-4 use new wallet package #778

CR
8453eb5
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
Codecov / codecov/project succeeded Oct 25, 2023 in 0s

53.08% (+9.30%) compared to d26586c

View this Pull Request on Codecov

53.08% (+9.30%) compared to d26586c

Details

Codecov Report

Attention: 261 lines in your changes are missing coverage. Please review.

Comparison is base (d26586c) 43.77% compared to head (8453eb5) 53.08%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #778      +/-   ##
==========================================
+ Coverage   43.77%   53.08%   +9.30%     
==========================================
  Files          41       40       -1     
  Lines        2652     2287     -365     
==========================================
+ Hits         1161     1214      +53     
+ Misses       1347      908     -439     
- Partials      144      165      +21     
Files Coverage Δ
internal/handler/wallet/testsUtils.go 100.00% <100.00%> (+35.29%) ⬆️
pkg/assets/asset.go 62.94% <100.00%> (ø)
pkg/network/interface.go 100.00% <ø> (ø)
pkg/wallet/filesystem.go 54.68% <ø> (ø)
pkg/wallet/retrocompatibility.go 37.77% <ø> (ø)
pkg/wallet/testUtils.go 100.00% <100.00%> (ø)
internal/handler/wallet/add_asset.go 55.88% <80.00%> (ø)
internal/handler/wallet/delete.go 62.00% <90.90%> (+0.77%) ⬆️
internal/handler/wallet/api.go 91.42% <88.88%> (+1.10%) ⬆️
internal/handler/wallet/delete_asset.go 37.50% <33.33%> (ø)
... and 18 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.