This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
add sbix fallback twemoji font (and bump to emoji 12) #3050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EDIT: fixed by matrix-org/twemoji-colr@1645460 From a quick visual inspection, it's now in sync with COLR. |
ara4n
changed the title
turt2live
approved these changes
Jun 3, 2019
| @@ -114,7 +114,13 @@ export async function fixupColorFonts() { | |||
| // weights for the emoji to appear in bold messages, etc. | |||
| document.fonts.add(new FontFace("Twemoji", path, { weight: 600 })); | |||
| document.fonts.add(new FontFace("Twemoji", path, { weight: 700 })); | |||
| } else { | |||
| // fall back to SBIX, generated via https://github.com/matrix-org/twemoji-colr/tree/matthew/sbix | |||
There was a problem hiding this comment.
it's very unfortunate that we're not able to use upstream for this. I have many fears about us forgetting to upgrade, or falling behind, or otherwise not maintaining our fork very well.
There was a problem hiding this comment.
yup, but i see no alternative sadly.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should fix element-hq/element-web#9891 and element-hq/element-web#9900