-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSC4186: Simplified Sliding Sync #4186
base: main
Are you sure you want to change the base?
Changes from all commits
8cc34df
456db3b
6fe4ba7
a5dc74b
4c47844
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -0,0 +1,392 @@ | ||||||
# MSC4186: Simplified Sliding Sync | ||||||
|
||||||
The current `/sync` endpoint scales badly as the number of rooms on an account increases. It scales badly because all | ||||||
rooms are returned to the client, incremental syncs are unbounded and slow down based on how long the user has been | ||||||
offline, and clients cannot opt-out of a large amount of extraneous data such as receipts. On large accounts with | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can't data be removed with filters? (See There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Specifically, I believe you can opt-out of receipts with One of the difficulties with v3 sync filtering in general is that performance can vary wildly wildly depending on server implementation details. The spec doesn't indicate which fast-paths should exist, and whether or not you hit a fast-path can also affect how many events are returned in the sync window (matrix-org/matrix-spec#1887). |
||||||
thousands of rooms, the initial sync operation can take tens of minutes to perform. This significantly delays the | ||||||
initial login to Matrix clients, and also makes incremental sync very heavy when resuming after any significant pause in | ||||||
usage. | ||||||
|
||||||
Note: this is a “simplified” version of the sliding sync API proposed in | ||||||
[MSC3575](https://github.com/matrix-org/matrix-spec-proposals/pull/3575), based on paring back that API based | ||||||
on real world use cases and usages. | ||||||
|
||||||
|
||||||
# Goals | ||||||
|
||||||
This improved `/sync` mechanism has a number of goals: | ||||||
|
||||||
- Sync time should be independent of the number of rooms you are in. | ||||||
- Time from opening of the app (when already logged in) to confident usability should be as low as possible. | ||||||
- Time from login on existing accounts to usability should be as low as possible. | ||||||
- Bandwidth should be minimized. | ||||||
- Support lazy-loading of things like read receipts (and avoid sending unnecessary data to the client) | ||||||
- Support informing the client when room state changes from under it, due to state resolution. | ||||||
- Clients should be able to work correctly without ever syncing in the full set of rooms they’re in. | ||||||
- Don’t incremental sync rooms you don’t care about. | ||||||
- Servers should not need to store all past since tokens. If a since token has been discarded we should gracefully | ||||||
degrade to initial sync. | ||||||
|
||||||
These goals shaped the design of this proposal. | ||||||
|
||||||
|
||||||
# Proposal | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. How does SSS interact with the ignored user list? In /v3/sync, the server omits events sent by ignored users, requiring the client to perform a second initial sync if they want to retroactively see messages when unignoring. The choice to do server-side ignored user filtering in sync also doesn't really simplify client implementation, because you still need client-side filtering for events received before the user was ignored. My preference would be to drop this requirement entirely for SSS, now that we have a chance to do it in a backwards-compatible way. |
||||||
|
||||||
The core differences between sync v2 and simplified sliding sync are: | ||||||
|
||||||
- The server initially only sends the most recent N rooms to the client (where N is specified by the client), which then | ||||||
can paginate in older rooms in subsequent requests | ||||||
- The client can configure which information the server will return for different sets of rooms (e.g. a smaller timeline | ||||||
limit for older rooms). | ||||||
- The client can filter what rooms it is interested in | ||||||
- The client can maintain multiple sync loops (with some caveats) | ||||||
erikjohnston marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
- This is useful for e.g. iOS clients which have a separate process to deal with notifications, as well as allowing | ||||||
the app to split handling of things like encryption entirely from room data. | ||||||
|
||||||
The basic operation is similar between sync v2 and simplified sliding sync: both use long-polling with tokens to fetch | ||||||
updates from the server. I.e., the basic operation of both APIs is to do an “initial” request and then repeatedly call | ||||||
the API supplying the token returned in the previous response in the subsequent “incremental” request. | ||||||
|
||||||
|
||||||
## Lists and room subscriptions | ||||||
|
||||||
The core component of a sliding sync request is “lists”, which specify what information to return about which rooms. | ||||||
Each list specifies some filters on rooms (e.g. ignore spaces), the range of filtered rooms to select (e.g. the most | ||||||
recent 20 filtered rooms), and the config for the data to return for those rooms (e.g. the required state, timeline | ||||||
limit, etc). The order of rooms is always done based on when the server received the most recent event for the room. | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. "Stream order" in synapse parlance? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, should standardize this type of language.
Suggested change
|
||||||
|
||||||
The client can also specify config for specific rooms if it has their room ID, these are known as room subscriptions. | ||||||
|
||||||
Multiple lists and subscriptions can be specified in a request. If a room matches multiple lists/subscriptions then the | ||||||
config is “combined” to be the superset of all configs (e.g. take the maximum timeline limit). See below for the exact | ||||||
algorithm. | ||||||
Comment on lines
+60
to
+62
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. So lists + subscriptions replace filters? |
||||||
|
||||||
The server tracks what data has been sent to the client in which rooms. If a room matches a list or subscription that | ||||||
hasn’t been sent down before, then the server will respond with the full metadata about the room indicated by `initial: | ||||||
true`. If a room stops matching a list (i.e. it falls out of range) then no further updates will be sent until it starts | ||||||
matching a list again, at which point the missing updates (limited by the `timeline_limit`) will be sent down. However, | ||||||
as clients are now expected to paginate all rooms in the room list in the background (in order to correctly order and | ||||||
search them), the act of a room falling out of range is a temporary edge-case. | ||||||
|
||||||
|
||||||
## Pagination | ||||||
|
||||||
Pagination is achieved by the client increasing the ranges of one (or more) lists. | ||||||
|
||||||
For example an initial request might have a list called `all_rooms` specifying a range of `0..20` in the initial | ||||||
request, and the server will respond with the top 20 rooms (by most recently updated). On the second request the client | ||||||
may change the range to `0..100`, at which point the server will respond with the top 100 rooms that either a) weren’t | ||||||
sent down in the first request, or b) have updates since the first request. | ||||||
|
||||||
Clients can increase and decrease the ranges as they see fit. A common approach would be to start with a small window | ||||||
and grow that until the range covers all the rooms. After some threshold of the app being offline it may reduce the | ||||||
range back down and incrementally grow it again. This allows for ensuring that a limited amount of data is requested at | ||||||
once, to improve response times. | ||||||
|
||||||
|
||||||
## Connections | ||||||
|
||||||
Clients can have multiple “connections” (i.e. sync loops) with the server, so long as each connection has a different | ||||||
`conn_id` set in the request. | ||||||
|
||||||
Clients must only have a single request in-flight at any time per connection (clients can have multiple connections by | ||||||
specifying a unique `conn_id`). If a client needs to send another request before receiving a response to an in-flight | ||||||
request (e.g. for retries or to change parameters) the client *must* cancel the in-flight request (at the HTTP level) | ||||||
and *not* process any response it receives for it. | ||||||
|
||||||
In particular, a client must use the returned `pos` value in a response as the `since` param in exactly one request that | ||||||
the client will process the response for. Clients must be careful to ensure that when processing a response any new | ||||||
requests use the new `pos`, and any in-flight requests using an old `pos` are canceled. | ||||||
|
||||||
The server cannot assume that a client has received a response until it receives a new request with the `since` token | ||||||
set to the `pos` it returned in the response. The server must ensure that any per-connection state it tracks correctly | ||||||
handles receiving multiple requests with the same `since` token (e.g. the client retries the request or decides to | ||||||
cancel and resend a request with different parameters). | ||||||
|
||||||
A server may decide to “expire” connections, either to free resources or because the server thinks it would be faster | ||||||
for the client to start from scratch (e.g. because there are many updates to send down). This is done by responding with | ||||||
a 400 HTTP status and an error code of `M_UNKNOWN_POS`. | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Since this is a new error code(?) I'd prefer spelling out |
||||||
|
||||||
|
||||||
## List configuration | ||||||
|
||||||
**TODO**, these are the same as in [MSC3575](https://github.com/matrix-org/matrix-spec-proposals/pull/3575): | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please copy them here so this is self contained. |
||||||
|
||||||
- Required state format | ||||||
- The filters | ||||||
- Lazy loading of members | ||||||
- Combining room config | ||||||
|
||||||
|
||||||
## Room config changes | ||||||
|
||||||
When a room comes in and out of different lists or subscriptions, the effective `timeline_limit` and `required_state` | ||||||
parameters may change. This section outlines how the server should handle these cases. | ||||||
|
||||||
If the `timeline_limit` *increases* then the server *may* choose to send down more historic data. This is to support the | ||||||
ability to get more history for certain rooms, e.g. when subscribing to the currently visible rooms in the list to | ||||||
precache their history. This is done by setting `unstable_expanded_timeline` to true and sending down the last N events | ||||||
(this may include events that have already been sent down). The server may choose not to do this if it believes it has | ||||||
already sent down the appropriate number of events. | ||||||
Comment on lines
+126
to
+130
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't really get this entire section. Why is it unstable? |
||||||
|
||||||
If new entries are added to `required_state` then the server must send down matching current state events. | ||||||
|
||||||
|
||||||
## Extensions | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. My understanding is that this MSC doesn't have any support for timeline filtering. The SS MSC called this out explicitly, and it would probably be good to do that here as well. Timeline filtering on /v3/sync is used heavily by some bot and tool clients. |
||||||
|
||||||
We anticipate that as more features land in Matrix, different kinds of data will also want to be synced to clients. Sync | ||||||
v2 did not have any first-class support to opt-in to new data. Sliding Sync does have support for this via "extensions". | ||||||
Extensions also allow this proposal to be broken up into more manageable sections. Extensions are requested by the | ||||||
client in a dedicated extensions block. | ||||||
|
||||||
In an effort to reduce the size of this proposal, extensions will be done in separate MSCs. There will be extensions | ||||||
for: | ||||||
|
||||||
- To Device Messaging \- MSC3885 | ||||||
- End-to-End Encryption \- MSC3884 | ||||||
- Typing Notifications \- MSC3961 | ||||||
- Receipts \- MSC3960 | ||||||
- Presence \- presence in sync v2: spec | ||||||
- Account Data \- account\_data in sync v2: MSC3959 | ||||||
- Threads | ||||||
|
||||||
**TODO** explain how these interact with the room lists, this is the same as in | ||||||
[MSC3575](https://github.com/matrix-org/matrix-spec-proposals/pull/3575) | ||||||
|
||||||
## Request format | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. which of these are required and which optional? |
||||||
|
||||||
```javascript | ||||||
{ | ||||||
"conn_id": "<conn_id>", // Client chosen ID of the connection, c.f. "Connections" | ||||||
|
||||||
// The set of room lists | ||||||
"lists": { | ||||||
// An arbitrary string which the client is using to refer to this list for this connection. | ||||||
"<list-name>": { | ||||||
|
||||||
// Sliding window ranges, c.f. Lists and room subscriptions | ||||||
"ranges": [[0, 10]], | ||||||
Comment on lines
+167
to
+168
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is a list of lists really helpful here? Are these numbers inclusive? |
||||||
|
||||||
// Filters to apply to the list. | ||||||
"filters": { | ||||||
// Flag which only returns rooms present (or not) in the DM section of account data. | ||||||
// If unset, both DM rooms and non-DM rooms are returned. If false, only non-DM rooms | ||||||
// are returned. If true, only DM rooms are returned. | ||||||
"is_dm": true|false|null, | ||||||
|
||||||
// Flag which only returns rooms which have an `m.room.encryption` state event. If unset, | ||||||
// both encrypted and unencrypted rooms are returned. If false, only unencrypted rooms | ||||||
// are returned. If true, only encrypted rooms are returned. | ||||||
"is_encrypted": true|false|null, | ||||||
|
||||||
// Flag which only returns rooms the user is currently invited to. If unset, both invited | ||||||
// and joined rooms are returned. If false, no invited rooms are returned. If true, only | ||||||
// invited rooms are returned. | ||||||
"is_invite": true|false|null, | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. How will knocks and left rooms be handled? Maybe this should be a string and be the current membership of the user? |
||||||
|
||||||
// If specified, only rooms where the `m.room.create` event has a `type` matching one | ||||||
// of the strings in this array will be returned. If this field is unset, all rooms are | ||||||
// returned regardless of type. This can be used to get the initial set of spaces for an account. | ||||||
// For rooms which do not have a room type, use 'null' to include them. | ||||||
"room_types": [ ... ], | ||||||
|
||||||
// Same as "room_types" but inverted. This can be used to filter out spaces from the room list. | ||||||
// If a type is in both room_types and not_room_types, then not_room_types wins and they are | ||||||
// not included in the result. | ||||||
"not_room_types": [ ... ], | ||||||
}, | ||||||
|
||||||
// The maximum number of timeline events to return per response. | ||||||
"timeline_limit": 10, | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||||||
|
||||||
// Required state for each room returned. An array of event type and state key tuples. | ||||||
// Elements in this array are ORd together to produce the final set of state events | ||||||
// to return. One unique exception is when you request all state events via ["*", "*"]. When used, | ||||||
// all state events are returned by default, and additional entries FILTER OUT the returned set | ||||||
// of state events. These additional entries cannot use '*' themselves. | ||||||
// For example, ["*", "*"], ["m.room.member", "@alice:example.com"] will _exclude_ every m.room.member | ||||||
// event _except_ for @alice:example.com, and include every other state event. | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I find this confusing.
Okay, so
Here we have an additional tuple. Its first member is an exclude directive modifying the wildcard tuple, just as expected. But its second member is an include directive modifying the first part of the tuple itself? Is that right? Why overload a single tuple to both modify the preceding wildcard tuple and modify itself? This seems inconsistent to me. Why overload it to be both an exclude and an include directive? I suppose it might be a convenient way to succinctly express commonly wanted filters, but it makes the earlier statement, "additional entries FILTER OUT the returned set of state events to return," something of a contradiction. If this really is the intent, I think some clarification and elaboration would be helpful. At the very least, rephrasing to remove the apparent contradiction. As it stands, this section leaves me wondering if a mistake was introduced in one of the drafts that led here. I'm not confident implementing a client based on it. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This behavior comes from the prior art in MSC3575. Proposed alternative in #4186 (comment) which is a lot more straight-forward 👍 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I agree with that proposal: Using (It follows the convention established by There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Would it then make sense to merge They reference different sub-fields, though: I suppose merging them could always be considered in a future protocol version, if real-world usage proves that doing so would be an improvement. |
||||||
// In addition, ["*", "*"], ["m.space.child", "*"] is an error, the m.space.child filter is not | ||||||
// required as it would have been returned anyway. | ||||||
Comment on lines
+202
to
+210
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why not |
||||||
"required_state": [ ... ], | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Clarify that This ensures that we send down membership updates whenever we see it change in the timeline. This allows clients to cache the membership list for as long as it doesn't get a gappy sync, but still ensures for large gaps the server doesn't need to send down all membership changes. Reference: element-hq/synapse#17929 |
||||||
} | ||||||
}, | ||||||
|
||||||
// The set of room subscriptions | ||||||
"room_subscriptions": { | ||||||
// The key is the room to subscribe to. | ||||||
"!foo:example.com": { | ||||||
Comment on lines
+216
to
+218
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Re-adding this discussion from the other MSC3575: What should happen if you try to subscribe to a room you are not part of (or not allowed)? The easy option would be to ignore it but then clients have no feedback about what they did wrong. Perhaps entries in the Can you subscribe to a public |
||||||
// These have the same meaning as in `lists` section | ||||||
"timeline_limit": 10, | ||||||
"required_state": [ ... ], | ||||||
} | ||||||
}, | ||||||
|
||||||
// c.f. "Extensions" | ||||||
"extensions": { | ||||||
} | ||||||
} | ||||||
``` | ||||||
|
||||||
|
||||||
## Response format | ||||||
|
||||||
```javascript | ||||||
{ | ||||||
// The position to use as the `since` token in the next sliding sync request. | ||||||
// c.f. Connections. | ||||||
"pos": "<opaque string>", | ||||||
Comment on lines
+236
to
+238
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think there was an effort to standardize pagination terminology? |
||||||
|
||||||
// Information about the lists supplied in the request. | ||||||
"lists": { | ||||||
// Matches the list name supplied by the client in the request | ||||||
"<list-name>" { | ||||||
// The total number of rooms that match the list's filter. Note that rooms can be in | ||||||
// multiple lists, so may be double counted. | ||||||
"count": 1234, | ||||||
} | ||||||
}, | ||||||
|
||||||
// Aggregated rooms from lists and room subscriptions. There will be one entry per room, even if | ||||||
// the room appears in multiple lists and/or room subscriptions. | ||||||
"rooms": { | ||||||
Comment on lines
+250
to
+252
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Clarify which rooms should be showing up. We want to return every room where the user has membership except rooms that the user has left themselves; unless "newly left" (left since the last incremental sync A To say it another way, here is a list:
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should you only include There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I also had that in mind but I'm not sure (could go either way). It's kinda the same as an unsolicited invite (optionally followed by a kick/ Ideally, we probably wouldn't show those kind of |
||||||
"!foo:example.com": { | ||||||
// The room name (as specified by any `m.room.name` event), if one exists. Only sent initially | ||||||
// and when it changes. | ||||||
"name": str|null, | ||||||
MadLittleMods marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
// The room avatar, if one exists. Only sent initially and when it changes. | ||||||
"avatar_url": str|null, | ||||||
// The "heroes" for the room, if there is no room name. Only sent initially and when it changes. | ||||||
"heroes": [ | ||||||
{"user_id":"@alice:example.com","displayname":"Alice","avatar_url":"mxc://..."}, | ||||||
], | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do the Sync v2 says this:
But I think that's because One alternative is to match Sync v2 and only list the user ID's in
Comment on lines
+260
to
+262
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. One weird corner with the current spec: If the room doesn't have a name set and the user is invited/knock to the room, we don't have any Related to matrix-org/matrix-spec#380 This was solved for partial-joins via MSC3943 Not necessarily a blocker but just calling out something that won't work completely until that spec issue is solved. |
||||||
|
||||||
// Flag which is set when this is the first time the server is sending this data on this connection. | ||||||
// When set the client must replace any stored metadata for the room with the new data. In | ||||||
// particular, the state must be replaced with the state in `required_state`. | ||||||
"initial": true|null, | ||||||
|
||||||
// Same as in sync v2. Indicates whether there are more events to fetch than those in the timeline. | ||||||
"limited:" true|null, | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Are the options in the request and response supposed to be in a union with Isn't it the convention in the spec that the property is omitted entirely rather than given the value (For clarity, this is something that jumps out at me since frequently people don't realise omitting a property and giving the value null are distinct things in JSON. Again, I'm not sure what the convention is for the CS-API though.) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hmm, seems like But this does not imply a union with There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It might be better to rewrite this section using JSONSchema so that the intent is clearer in either case.
Comment on lines
+269
to
+270
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Clarify what Sync v2 in Synapse is a bit crazy with the logic probably because the spec isn't clear. The existing definition seems accurate "Indicates whether there are more events to fetch than those in the timeline." Could maybe clarify that you can be
Comment on lines
+269
to
+270
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Clarify when to add Currently, it's done in Sync v2 and Sliding Sync in Synapse when There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @erikjohnston unearthed some more context in MSC2675 and relevant Synapse PR |
||||||
// Indicates if we have "expanded" the timeline due to the timeline_limit changing, c.f. Room config | ||||||
// changes above. | ||||||
"unstable_expanded_timeline": true|null, | ||||||
// The list of events, sorted least to most recent. | ||||||
"timeline": [ ... ], | ||||||
// The current state of the room as a list of events. This is the full state if `initial` | ||||||
// state is set, otherwise it is a delta from the previous sync. | ||||||
"required_state": [ ... ], | ||||||
// The number of timeline events which have just occurred and are not historical. | ||||||
// The last N events are 'live' and should be treated as such. | ||||||
"num_live": 1, | ||||||
// Same as sync v2, passed to `/messages` to fetch more past events. | ||||||
"prev_batch": "...", | ||||||
|
||||||
// For invites this is the stripped state of the room at the time of invite | ||||||
"invite_state": [ .. ], | ||||||
|
||||||
// For knocks this is the stripped state of the room at time of knock | ||||||
"knock_state": [ .. ], | ||||||
Comment on lines
+285
to
+289
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As mentioned in a comment below it would be super useful to have a separate field indicating the user's membership state in a room instead of relying on some rules around Also note the current simplified sliding sync version implementation in Synapse uses a single There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There should also be a |
||||||
|
||||||
// Whether the room is a DM room. | ||||||
"is_dm": true|null, | ||||||
|
||||||
// An opaque integer that can be used to sort the rooms by "Bump Stamp" | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
We may also precise that |
||||||
"bump_stamp": 1, | ||||||
Comment on lines
+294
to
+295
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Where is this defined? |
||||||
|
||||||
// These are the same as sync v2. | ||||||
"joined_count": 1, | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should be precised that |
||||||
"invited_count": 1, | ||||||
"notification_count": 1, | ||||||
"highlight_count": 1, | ||||||
} | ||||||
}, | ||||||
|
||||||
"extensions": { | ||||||
}, | ||||||
} | ||||||
``` | ||||||
|
||||||
# Example usage | ||||||
|
||||||
This section gives an example of how a client can use this API (roughly based on how Element X currently uses the API). | ||||||
|
||||||
When the app starts up it configures a single list with a range of `[0, 19]` (to get the top 20 rooms) and a | ||||||
`timeline_limit` of 1. This returns quickly with the top 20 rooms (or just the changes in the top 20 rooms if a token | ||||||
was specified). | ||||||
|
||||||
The client then increases the range (in the next request) to `[0, 99]`, which will return the next 80 rooms. The server | ||||||
may sort the rooms differently than they are returned by the server (e.g. they may ignore reactions for sorting | ||||||
purposes). Note: the range here matches 100 rooms, however we only send the 80 rooms that we didn't send down in the | ||||||
previous request. | ||||||
|
||||||
The client can use room subscriptions, with a `timeline_limit` of 20, to preload history for the top rooms. This means | ||||||
that if the user clicks on one of the top rooms the app can immediately display a screens worth of history. (An | ||||||
alternative would be to have a second list with a static range of `[0, 19]` and a `timeline_limit` of 20. The downside | ||||||
is that the clients may use a different order for the room list and so always fetching extra events for the top 20 rooms | ||||||
may return more data than required.) | ||||||
|
||||||
The client can keep increasing the list range in increments to pull in the full list of rooms. The client uses the | ||||||
returned `count` for the list to know when to stop expanding the list. | ||||||
|
||||||
The client *may* decided to reduce the range back to `[0, 19]` (and then subsequently incrementally expand the range), | ||||||
this can be done. | ||||||
|
||||||
When the client is expecting a fast response (e.g. while expanding the lists), it should set the `timeout` parameter to | ||||||
0 to ensure the server doesn't block waiting for new data. This can easily happen if the app starts and sends the first | ||||||
request with a `since` parameter, if the client shows a spinner but doesn't set a timeout then the request may take a | ||||||
long time to return (if there were no updates to return). | ||||||
|
||||||
|
||||||
# Alternatives / changes | ||||||
|
||||||
There are a number of potential changes that we could make. | ||||||
|
||||||
## Pagination | ||||||
|
||||||
In practice, having the client specify the ranges to use for the lists is often sub-optimal. The client generally wants | ||||||
to have the sync request return as quickly as possible, but it doesn't know how much data the server has to return and | ||||||
so whether to increase or decrease the range. | ||||||
|
||||||
An alternative is for the client to specify a `page_size`, where the server sends down at most `page_size` number of | ||||||
rooms. If there are more rooms to send to the client (beyond `page_size`), then the client can request to "paginate" in | ||||||
these missed updates in subsequent updates. | ||||||
|
||||||
Since this would require client side changes, this should be explored in a separate MSC. | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Doesn't all of this require client side changes? |
||||||
|
||||||
## Timeline event trickling | ||||||
|
||||||
If the `timeline_limit` is increased then the server will send down historic data (c.f. "Room config changes"), which | ||||||
allows the clients to easily preload more history in recent rooms. | ||||||
|
||||||
This mechanism is fiddly to implement, and ends up resending down events that we have previously sent to the client. | ||||||
|
||||||
A simpler alternative is to use `/messages` to fetch the history. This has two main problems: 1) clients generally want | ||||||
to preload history for multiple rooms at once, and 2) `/messages` can be slow if it tries to backfill over federation. | ||||||
|
||||||
We could implement a bulk `/messages` endpoint, where the client would specify multiple rooms and `prev_batch` tokens. | ||||||
We can also add a flag to disable attempting to backfill over pagination (to match the behaviour of the sync timeline). | ||||||
Comment on lines
+357
to
+368
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please kill Previous conversation: |
||||||
|
||||||
## `required_state` response format | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This section seems to contradict the opening that this MSC solves the issue of clients having incorrect state. |
||||||
|
||||||
The format of returned state in `required_state` is a list of events. This does now allow the server to indicate if a | ||||||
"state reset" has happened which removed an entry from the state entirely (rather than it being replaced with another | ||||||
event). | ||||||
|
||||||
This is particularly problematic if the user gets "state reset" out of the room, where the server has no mechanism to | ||||||
indicate to the client that the user has effectively left the room (the server has no leave event to return). | ||||||
|
||||||
We may want to allow special entries in the `required_state` list of the form | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Surely this isn't a nice-to-have but a requirement, otherwise we end up back in matrix-org/matrix-spec#1209 |
||||||
`{"type": .., "state_key": .., content: null}` to indicate that the state entry has been removed. | ||||||
Comment on lines
+372
to
+380
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is pretty serious and I don't think we can leave it up to clients to figure out somehow. Since that requires client authors to both be extremely knowledgeable about how room state works and also write perfect code. The chances of both of those happening is slim. For example, I tried to write some code to track room state from legacy You can read more about the way Draupnir collects state here https://marewolf.me/posts/draupnir/2402.html#development-room-state-tracking. But it would be good if clients didn't need to calculate state deltas at all and there was more specialized API support for that. There'd need to be consideration for how such an API would interact with timeline gaps if it was done alongside |
||||||
|
||||||
|
||||||
# Security considerations | ||||||
|
||||||
Care must be taken, as with sync v2, to ensure that only the data that the user is authorized to see is returned in the | ||||||
response. | ||||||
Comment on lines
+385
to
+386
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This should be expanded to explain what this means. In terms of state:
In terms of timeline events, this probably depends solely on |
||||||
|
||||||
|
||||||
# Unstable prefix | ||||||
|
||||||
The unstable URL for simplified sliding sync is `/org.matrix.simplified_msc3575/sync`. The flag in `/versions` is | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
`org.matrix.simplified_msc3575`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation requirements:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Current implementations to my knowledge:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Synapse server implementation
Maybe it's easiest to point to the main directories where the code lives:
element-hq/synapse
->synapse/rest/client/sync.py#L782
element-hq/synapse
->synapse/handlers/sliding_sync/
element-hq/synapse
->tests/rest/client/sliding_sync/
The PRs between @MadLittleMods and @erikjohnston with the ~A-Sync label are also a pretty good encapsulation: