refactor: reduce usage of ForkStorage outside inner module
#539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # crates/core/src/node/eth.rs # crates/core/src/node/in_memory.rs # crates/core/src/node/in_memory_ext.rs # crates/core/src/node/inner/in_memory_inner.rs # crates/core/src/utils.rs
popzxc
approved these changes
Jan 15, 2025
mm-zk
added a commit
that referenced
this pull request
Jan 17, 2025
* refactor: reduce usage of `ForkStorage` outside `inner` module (#539) * reduce usage of `ForkStorage` outside `inner` module * adapt for zkos * fix destination path (#541) * fix: anvil-zksync able to start even if the port is busy (#542) * fix: closes #512 - start instance even if port is busy * chore: apply make lint:fix * chore: refactor test to make use of anvil-zksync instance * chore: remove no longer needed deps * chore: remove no longer needed deps * chore: bump actions/upload-artifact: v3 to v4 due to CI fail * chore: bump actions/upload-artifact / download: v3 to v4 due to CI fail * compilation fixes --------- Co-authored-by: Daniyar Itegulov <[email protected]> Co-authored-by: Nisheeth Barthwal <[email protected]> Co-authored-by: Dustin Brickwood <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What 💻
Smaller PR this time :)
ForkStoragebasically has two sets of functionality:This PR removes external usages of
ForkStoragefor all purposes that fall under point 1Related to #535 (solves first half of the issue)
Why ✋
Encapsulate mutable storage, get rid of potential race conditions (e.g. before this PR it was possible to mutate storage in the middle of tx execution).