Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change fantoccini to use rustls-tls #3

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

PFWhite
Copy link
Contributor

@PFWhite PFWhite commented Jul 10, 2024

Proposed changes

Add fantoccini to use rust tls instead of openssl
Fixes #2

Types of changes

What types of changes does your code introduce to ScoutLang?

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

@maxmindlin
Copy link
Owner

Thanks for the PR! (Ignore the failing actions, those shouldnt even be running on PRs). Did you confirm that this fixes the openssl install error?

@PFWhite
Copy link
Contributor Author

PFWhite commented Jul 10, 2024

I was able to get it running via cargo run and watch it work in the repl.

Very cool software you have here and I'm looking forward to putting it to use.

@maxmindlin
Copy link
Owner

Thanks so much for the contribution! Looking forward to more

@maxmindlin maxmindlin merged commit 0a51fdb into maxmindlin:main Jul 10, 2024
5 of 7 checks passed
@PFWhite PFWhite deleted the change-fantoccini-tls branch July 10, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependencies not clear
2 participants