Skip to content

Commit

Permalink
Merge pull request dolphin-emu#13189 from mitaclaw/gdb-stub-signal-br…
Browse files Browse the repository at this point in the history
…eakpoints

GDBStub: Signal Breakpoint Changes To Host
  • Loading branch information
JMC47 authored Nov 16, 2024
2 parents 7f25e05 + 62d7166 commit 050f5df
Show file tree
Hide file tree
Showing 8 changed files with 27 additions and 0 deletions.
4 changes: 4 additions & 0 deletions Source/Android/jni/MainAndroid.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,10 @@ void Host_PPCSymbolsChanged()
{
}

void Host_PPCBreakpointsChanged()
{
}

void Host_RefreshDSPDebuggerWindow()
{
}
Expand Down
1 change: 1 addition & 0 deletions Source/Core/Core/Host.h
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ bool Host_TASInputHasFocus();

void Host_Message(HostMessageID id);
void Host_PPCSymbolsChanged();
void Host_PPCBreakpointsChanged();
void Host_RefreshDSPDebuggerWindow();
void Host_RequestRenderWindowSize(int width, int height);
void Host_UpdateDisasmDialog();
Expand Down
2 changes: 2 additions & 0 deletions Source/Core/Core/PowerPC/GDBStub.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,7 @@ static void RemoveBreakpoint(BreakpointType type, u32 addr, u32 len)
INFO_LOG_FMT(GDB_STUB, "gdb: removed a memcheck: {:08x} bytes at {:08x}", len, addr);
}
}
Host_PPCBreakpointsChanged();
}

static void Nack()
Expand Down Expand Up @@ -896,6 +897,7 @@ static bool AddBreakpoint(BreakpointType type, u32 addr, u32 len)
INFO_LOG_FMT(GDB_STUB, "gdb: added {} memcheck: {:08x} bytes at {:08x}", static_cast<int>(type),
len, addr);
}
Host_PPCBreakpointsChanged();
return true;
}

Expand Down
4 changes: 4 additions & 0 deletions Source/Core/DolphinNoGUI/MainNoGUI.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,10 @@ void Host_PPCSymbolsChanged()
{
}

void Host_PPCBreakpointsChanged()
{
}

void Host_RefreshDSPDebuggerWindow()
{
}
Expand Down
6 changes: 6 additions & 0 deletions Source/Core/DolphinQt/Host.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,12 @@ void Host_PPCSymbolsChanged()
QueueOnObject(QApplication::instance(), [] { emit Host::GetInstance()->PPCSymbolsChanged(); });
}

void Host_PPCBreakpointsChanged()
{
QueueOnObject(QApplication::instance(),
[] { emit Host::GetInstance()->PPCBreakpointsChanged(); });
}

// We ignore these, and their purpose should be questioned individually.
// In particular, RequestRenderWindowSize, RequestFullscreen, and
// UpdateMainFrame should almost certainly be removed.
Expand Down
4 changes: 4 additions & 0 deletions Source/Core/DolphinTool/ToolHeadlessPlatform.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,10 @@ void Host_PPCSymbolsChanged()
{
}

void Host_PPCBreakpointsChanged()
{
}

void Host_RefreshDSPDebuggerWindow()
{
}
Expand Down
3 changes: 3 additions & 0 deletions Source/DSPTool/StubHost.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@ std::vector<std::string> Host_GetPreferredLocales()
void Host_PPCSymbolsChanged()
{
}
void Host_PPCBreakpointsChanged()
{
}
void Host_RefreshDSPDebuggerWindow()
{
}
Expand Down
3 changes: 3 additions & 0 deletions Source/UnitTests/StubHost.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@ std::vector<std::string> Host_GetPreferredLocales()
void Host_PPCSymbolsChanged()
{
}
void Host_PPCBreakpointsChanged()
{
}
void Host_RefreshDSPDebuggerWindow()
{
}
Expand Down

0 comments on commit 050f5df

Please sign in to comment.