refactor: make use of helper functions in Arrow.Shuttles for changes

mbta · Nov 6, 2024 · bfb4fd6 · bfb4fd6
1 parent 7577fc4
commit bfb4fd6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 8 deletions.
diff --git a/lib/arrow/shuttles/shuttle.ex b/lib/arrow/shuttles/shuttle.ex
@@ -8,9 +8,7 @@ defmodule Arrow.Shuttles.Shuttle do
     field :shuttle_name, :string
     field :disrupted_route_id, :string
 
-    has_many :routes, Arrow.Shuttles.Route,
-      preload_order: [asc: :direction_id],
-      on_replace: :delete
+    has_many :routes, Arrow.Shuttles.Route, preload_order: [asc: :direction_id]
 
     timestamps(type: :utc_datetime)
   end

diff --git a/lib/arrow_web/live/shuttle_live/shuttle_live.ex b/lib/arrow_web/live/shuttle_live/shuttle_live.ex
@@ -164,9 +164,8 @@ defmodule ArrowWeb.ShuttleViewLive do
 
   def handle_event("edit", %{"shuttle_route" => shuttle_route_params}, socket) do
     shuttle = Shuttles.get_shuttle!(socket.assigns.shuttle_route.id)
-    changeset = Shuttles.change_shuttle(shuttle, shuttle_route_params)
 
-    case Arrow.Repo.update(changeset) do
+    case Arrow.Shuttles.update_shuttle(shuttle, shuttle_route_params) do
       {:ok, shuttle} ->
         {:noreply,
          socket
@@ -179,9 +178,7 @@ defmodule ArrowWeb.ShuttleViewLive do
   end
 
   def handle_event("create", %{"shuttle_route" => shuttle_route_params}, socket) do
-    changeset = Shuttles.change_shuttle(%Shuttle{}, shuttle_route_params)
-
-    case Arrow.Repo.insert(changeset) do
+    case Arrow.Shuttles.create_shuttle(shuttle_route_params) do
       {:ok, shuttle} ->
         {:noreply,
          socket