Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: expose arrow id for shuttle stops view #1012

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

meagharty
Copy link
Contributor

@meagharty meagharty commented Sep 17, 2024

Summary of changes

Asana Ticket: Relates to importing shuttles

Expose arrow id field so that we can use it to bulk update Arrow shuttle stops. In other situations, we can use stop_id under the stop's attributes

Reviewer Checklist

  • Meets ticket's acceptance criteria
  • Any new or changed functions have typespecs
  • Tests were added for any new functionality (don't just rely on Codecov)
  • This branch was deployed to the staging environment and is currently running with no unexpected increase in warnings, and no errors or crashes.

@meagharty meagharty force-pushed the meag/expose-shuttle-stops-id branch from a9e3c6c to 5ead3e9 Compare September 17, 2024 23:34
@meagharty meagharty requested review from a team and jzimbel-mbta and removed request for a team September 17, 2024 23:34
@meagharty meagharty force-pushed the meag/expose-shuttle-stops-id branch from 5ead3e9 to bc26aae Compare September 18, 2024 00:13
Copy link
Member

@jzimbel-mbta jzimbel-mbta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and makes sense to me!

@meagharty meagharty merged commit 4a0093f into master Sep 18, 2024
22 checks passed
@meagharty meagharty deleted the meag/expose-shuttle-stops-id branch September 18, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants