feat: add scaffolding for shuttle page #1019
Conversation
meagharty
requested review from
a team and
jzimbel-mbta
and removed request for
a team
| <.input field={f[:shuttle_name]} type="text" label="Shuttle name" /> | ||
| <.input | ||
| field={f[:status]} | ||
| type="select" |
There was a problem hiding this comment.
I have a PR open to fix a bug with the bootstrap styling for select inputs that was added to core_components: #1018
Right now this field has an error but it doesn't display properly to the user (it's hidden because it's not marked properly as is-invalid)
meagharty
changed the title
meagharty
force-pushed
the
meag/add-scaffolding-for-shuttle-page
branch
from
a62a8f2 to
e11a1bd
Compare
| @@ -231,4 +231,88 @@ defmodule Arrow.Shuttles do | |||
| def change_shape(%Shape{} = shape, attrs \\ %{}) do | |||
| Shape.changeset(shape, attrs) | |||
| end | |||
|
|
|||
| alias Arrow.Shuttles.Shuttle | |||
There was a problem hiding this comment.
Any reason for putting the alias here rather than at the top of the module? Is it sort of to separate the shape-related functions above from the shuttle-related functions below?
There was a problem hiding this comment.
Phoenix code generators automatically added this to the end of the file. I was thought of it as separation from the shape-related functions but I don't feel strongly about it (and I don't know how intentional it is from code gen).
There was a problem hiding this comment.
Oh interesting, I didn't even know this code was generated! Will take another look at Phoenix's codegen docs 👀
lib/arrow/shuttles.ex
Outdated
|
|
||
| @spec create_shuttle( | ||
| :invalid | ||
| | %{optional(:__struct__) => none(), optional(atom() | binary()) => any()} |
There was a problem hiding this comment.
I haven't seen the none type use like this before—does this essentially say that if you pass a map to create_shuttle/1, it has to be a bare map and not a struct? i.e., it's not allowed to have a :__struct__ key?
(I thought none / no_return was only useful for indicating that a function never returns, due to raising, throwing, terminating the process etc; so I'm not sure of its semantics in a typespec.)
There was a problem hiding this comment.
Woops, I'll remove, I didn't notice this.
This annotation was created by VsCode so I can't comment on why it generated the annotation like this. I must have accidentally added it at some point while viewing the file.
There was a problem hiding this comment.
Oh gotcha. I sometimes accidentally click those suggested typespecs and they're almost always totally crazy, especially when any kind of string argument / return is involved!
meagharty
force-pushed
the
meag/add-scaffolding-for-shuttle-page
branch
from
e11a1bd to
36040b5
Compare
meagharty
force-pushed
the
meag/add-scaffolding-for-shuttle-page
branch
from
36040b5 to
7203404
Compare
Summary of changes
Asana Ticket: Generate scaffolding for Create/View/Edit Shuttle Route Definition pages
Reviewer Checklist